-
-
Notifications
You must be signed in to change notification settings - Fork 50.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(Select): fix prefix text wrap and overlap with placeholder #51625
Conversation
Run & review this pull request in StackBlitz Codeflow. |
👁 Visual Regression Report for PR #51625 Failed ❌
Warning There are more diffs not shown in the table. Please check the Full Report for details. Important There are 10 diffs found in this PR: 🔄 10 changed.
|
WalkthroughThis pull request addresses a bug in the Select component where the prefix text would wrap and overlap with the placeholder. The issue was more evident when the prefix was in Chinese or English with spaces. The solution involves adjusting the CSS styles to prevent text wrapping and overlapping. Changes
|
More templates
commit: |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #51625 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 761 761
Lines 13547 13543 -4
Branches 3533 3533
=========================================
- Hits 13547 13543 -4 ☔ View full report in Codecov by Sentry. 🚨 Try these New Features:
|
visual diff 不太对。 |
e7e5775
to
fb19014
Compare
@afc163 已经本地验证过了视觉上是一致的(打开关闭 CSS Var 都试过了),但是 Diff 就是不过,不知道为神马 😢 |
fb19014
to
f3618aa
Compare
中文版模板 / Chinese template
🤔 This is a ...
🔗 Related Issues
Fix #51623
💡 Background and Solution
当 prefix 为中文或者英文带空格,默认的 Flex 布局压缩会导致 prefix 文字换行。之前由于 prefix demo 用的是单个英文单词,所以没有发现。
另外多选模式下 prefix 和 placeholder 和重叠是因为 -selection-wrap 没有 position: relative 所致。
📝 Change Log