Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Select align issue #51694

Merged
merged 11 commits into from
Nov 20, 2024
Merged

fix: Select align issue #51694

merged 11 commits into from
Nov 20, 2024

Conversation

zombieJ
Copy link
Member

@zombieJ zombieJ commented Nov 19, 2024

中文版模板 / Chinese template

🤔 This is a ...

  • 🆕 New feature
  • 🐞 Bug fix
  • 📝 Site / documentation improvement
  • 📽️ Demo improvement
  • 💄 Component style improvement
  • 🤖 TypeScript definition improvement
  • 📦 Bundle size optimization
  • ⚡️ Performance optimization
  • ⭐️ Feature enhancement
  • 🌐 Internationalization
  • 🛠 Refactoring
  • 🎨 Code style optimization
  • ✅ Test Case
  • 🔀 Branch merge
  • ⏩ Workflow
  • ❓ Other (about what?)

🔗 Related Issues

💡 Background and Solution

调整了一些排列组合的情况:

  • 单多选
  • 有无 Placeholder
  • 有无 Value
  • 状态
  • 变体
  • 高度

📝 Change Log

Language Changelog
🇺🇸 English Fix Select with prefix style issue with color, line break, status error.
🇨🇳 Chinese 修复 Select 的 prefix组合导致的颜色、折行、状态样式问题。

Copy link

stackblitz bot commented Nov 19, 2024

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

Copy link
Contributor

github-actions bot commented Nov 19, 2024

Preview is ready

Copy link
Contributor

github-actions bot commented Nov 19, 2024

👁 Visual Regression Report for PR #51694 Failed ❌

🎯 Target branch: master (7dfc5e3)
📖 View Full Report ↗︎

Expected (Branch master) Actual (Current PR) Diff
auto-complete-variant.compact.png auto-complete-variant.compact.png auto-complete-variant.compact.png auto-complete-variant.compact.png
auto-complete-variant.compact.png auto-complete-variant.compact.png auto-complete-variant.compact.css-var.png auto-complete-variant.compact.css-var.png
auto-complete-variant.dark.png auto-complete-variant.dark.png auto-complete-variant.dark.png auto-complete-variant.dark.png
auto-complete-variant.dark.png auto-complete-variant.dark.png auto-complete-variant.dark.css-var.png auto-complete-variant.dark.css-var.png
auto-complete-variant.default.png auto-complete-variant.default.png auto-complete-variant.default.png auto-complete-variant.default.png
auto-complete-variant.default.png auto-complete-variant.default.png auto-complete-variant.default.css-var.png auto-complete-variant.default.css-var.png
select-option-label-center.compact.png select-option-label-center.compact.png select-option-label-center.compact.png select-option-label-center.compact.png
select-option-label-center.compact.png select-option-label-center.compact.png select-option-label-center.compact.css-var.png select-option-label-center.compact.css-var.png

Warning

There are more diffs not shown in the table. Please check the Full Report for details.


Important

There are 24 diffs found in this PR: 🔄 24 changed.
Please check all items:

  • Checked all diffs in the full report
  • Visual diff is acceptable

Copy link

Walkthrough\nThis pull request addresses a bug fix related to the Select component in the Ant Design library. The changes focus on resolving issues with the alignment and styling of the Select component, particularly when using the prefix attribute. The fix involves adjustments to color, line breaks, and status errors.\n\n### Changes\n| Files | Summary |\n|-------|---------|\n| components/select/tests/snapshots/demo-extend.test.ts.snap, components/select/tests/snapshots/demo.test.tsx.snap | Updated snapshots for Select component tests to reflect changes in alignment and styling. |\n| components/select/demo/option-label-center.tsx | Modified demo to include various Select component configurations, testing different alignments and styles. |\n| components/select/style/index.ts, components/select/style/multiple.ts, components/select/style/single.ts, components/select/style/variants.ts | Adjusted CSS styles for Select component to fix alignment issues and improve handling of prefix styling. |

Copy link
Contributor

github-actions bot commented Nov 19, 2024

size-limit report 📦

Path Size
dist/antd.min.js 441.43 KB (+30 B 🔺)
dist/antd-with-locales.min.js 509.36 KB (+31 B 🔺)

li-jia-nan
li-jia-nan previously approved these changes Nov 19, 2024
Copy link

pkg-pr-new bot commented Nov 19, 2024

Copy link

cloudflare-workers-and-pages bot commented Nov 19, 2024

Deploying ant-design with  Cloudflare Pages  Cloudflare Pages

Latest commit: 94afecf
Status: ✅  Deploy successful!
Preview URL: https://55907b0c.ant-design.pages.dev
Branch Preview URL: https://select-prefix.ant-design.pages.dev

View logs

Copy link

codecov bot commented Nov 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (a1bc111) to head (94afecf).
Report is 14 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##            master    #51694    +/-   ##
==========================================
  Coverage   100.00%   100.00%            
==========================================
  Files          761       761            
  Lines        13555     13689   +134     
  Branches      3538      3576    +38     
==========================================
+ Hits         13555     13689   +134     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

@zombieJ zombieJ merged commit af7bce7 into master Nov 20, 2024
61 of 62 checks passed
@zombieJ zombieJ deleted the select-prefix branch November 20, 2024 03:54
@li-jia-nan
Copy link
Member

得补一下 5.22.2 的 ChangeLog,如果要发的话

aojunhao123 pushed a commit to aojunhao123/ant-design that referenced this pull request Nov 25, 2024
* fix: item align logic

* fix: placeholder style

* test: update snapshot

* fix: single align

* chore: add demo

* test: update snapshot

* fix: color

* fix: style

* fix: line height

* fix: borderless pos

* chore: base of prefix offset
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants