Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

AnthropicVertex does not expose with_options #566

Closed
dlebech opened this issue Jun 28, 2024 · 3 comments · Fixed by #578
Closed

AnthropicVertex does not expose with_options #566

dlebech opened this issue Jun 28, 2024 · 3 comments · Fixed by #578

Comments

@dlebech
Copy link
Contributor

dlebech commented Jun 28, 2024

What is it

The AnthropicVertex and AsyncAnthropicVertex clients do not seem to expose with_options(...) like the other clients.

Similar previous issue for Bedrock: #410

Example

> client.with_options(max_retries=num_retries).messages.create(...)
AttributeError: 'AsyncAnthropicVertex' object has no attribute 'with_options'

Thank you.
@rattrayalex
Copy link
Collaborator

Thanks for the report. We'll try to fix this soon, but a PR would be welcome.

@dlebech
Copy link
Contributor Author

dlebech commented Jul 7, 2024

Thanks @rattrayalex . Yes ok, I think can manage that. I will have a PR ready later today 👍

@dlebech dlebech mentioned this issue Jul 7, 2024
Merged
RobertCraigie added a commit that referenced this issue Jul 8, 2024
@dlebech @RobertCraigie
feat(vertex): add copy and with_options (#578)
b9827c1 
* feat(vertex): add copy and with_options

Closes #566

* move vertex client tests to a separate file

* add missing `credentials` argument to `copy()`

* minor cleanup

---------

Co-authored-by: Robert Craigie <robert@craigie.dev>
@RobertCraigie
Copy link
Collaborator

Thanks for the PR @dlebech!

stainless-app bot pushed a commit that referenced this issue Jul 8, 2024
@dlebech @RobertCraigie @stainless-bot
feat(vertex): add copy and with_options (#578)
fcd425f 
* feat(vertex): add copy and with_options

Closes #566

* move vertex client tests to a separate file

* add missing `credentials` argument to `copy()`

* minor cleanup

---------

Co-authored-by: Robert Craigie <robert@craigie.dev>
stainless-app bot pushed a commit that referenced this issue Jul 10, 2024
@dlebech @RobertCraigie @stainless-app
feat(vertex): add copy and with_options (#578)
1cf40ae 
* feat(vertex): add copy and with_options

Closes #566

* move vertex client tests to a separate file

* add missing `credentials` argument to `copy()`

* minor cleanup

---------

Co-authored-by: Robert Craigie <robert@craigie.dev>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(vertex): add copy and with_options dlebech/anthropic-sdk-python
3 participants
@dlebech @rattrayalex @RobertCraigie