Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(vertex): add copy and with_options #578

Merged
merged 4 commits into from
Jul 8, 2024

Conversation

dlebech
Copy link
Contributor

@dlebech dlebech commented Jul 7, 2024

Closes #566.

Note: It looks like there were no tests for the Vertex clients, so I added some, but only for the new copy feature.

@dlebech dlebech requested a review from a team as a code owner July 7, 2024 16:05
@RobertCraigie RobertCraigie changed the base branch from main to next July 8, 2024 08:31
Copy link
Collaborator

@RobertCraigie RobertCraigie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks very much! FYI I pushed a couple commits with some very minor changes.

@RobertCraigie RobertCraigie merged commit b9827c1 into anthropics:next Jul 8, 2024
@stainless-app stainless-app bot mentioned this pull request Jul 8, 2024
@dlebech dlebech deleted the vertex-with-options branch July 8, 2024 09:35
stainless-app bot pushed a commit that referenced this pull request Jul 8, 2024
* feat(vertex): add copy and with_options

Closes #566

* move vertex client tests to a separate file

* add missing `credentials` argument to `copy()`

* minor cleanup

---------

Co-authored-by: Robert Craigie <robert@craigie.dev>
stainless-app bot pushed a commit that referenced this pull request Jul 10, 2024
* feat(vertex): add copy and with_options

Closes #566

* move vertex client tests to a separate file

* add missing `credentials` argument to `copy()`

* minor cleanup

---------

Co-authored-by: Robert Craigie <robert@craigie.dev>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

AnthropicVertex does not expose with_options
2 participants