Skip to content
This repository has been archived by the owner on Oct 11, 2024. It is now read-only.

fix: Bump Account Nonce Post Regolith #11

Merged
merged 2 commits into from
Sep 7, 2023

Conversation

refcell
Copy link

@refcell refcell commented Sep 6, 2023

Description

Post-regolith, account nonces must be incremented for deposit transactions if they are contract creations even if the transaction halts.

@refcell refcell requested a review from clabby September 6, 2023 23:20
@refcell refcell self-assigned this Sep 6, 2023
Copy link

@clabby clabby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM apart from checking if regolith is active

crates/revm/src/evm_impl.rs Outdated Show resolved Hide resolved
@refcell refcell requested a review from clabby September 7, 2023 19:11
Copy link

@clabby clabby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm 👑

@refcell refcell merged commit 99a364e into clabby/op-revm Sep 7, 2023
@refcell refcell deleted the refcell/bump-nonce-post-regolith branch September 8, 2023 17:12
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants