Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove deprecated v1alpha1/ExternalEntity #6177

Merged
merged 1 commit into from
Apr 10, 2024

Conversation

hjiajing
Copy link
Contributor

@hjiajing hjiajing commented Apr 1, 2024

v1alpha1/ExternalEntity is not served for a long time, so it can be removed from the CRD definition.

luolanzone
luolanzone previously approved these changes Apr 1, 2024
Copy link
Contributor

@luolanzone luolanzone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@antoninbas antoninbas changed the title Remove depracated v1alpha1/ExternalEntity Remove deprecated v1alpha1/ExternalEntity Apr 1, 2024
@antoninbas antoninbas added action/release-note Indicates a PR that should be included in release notes. kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API. labels Apr 1, 2024
@antoninbas
Copy link
Contributor

Can we track down when we stopped serving the API an update docs/api.md accordingly?

@hjiajing
Copy link
Contributor Author

hjiajing commented Apr 2, 2024

Can we track down when we stopped serving the API an update docs/api.md accordingly?

Sure, I will update the Doc.

docs/api.md Outdated
@@ -81,3 +81,4 @@ These are the API group versions which are currently available when using Antrea
| CRD | CRD version | Introduced in | Deprecated in | Removed in |
|---|---|---|---|---|
| `ClusterGroup` | v1alpha2 | v1.0.0 | v1.1.0 | v2.0.0 |
| `ExternalEntity` | v1alpha1 | v0.10.0 | v1.7.0 | v2.0.0 |
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was actually deprecated in v0.11.0 by #1467

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed, thanks for the reminder.

v1alpha1/ExternalEntity is not served for a long time, so it can be
removed from the CRD definition.

Signed-off-by: hjiajing <hjiajing@vmware.com>
Copy link
Member

@tnqn tnqn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@antoninbas
Copy link
Contributor

/skip-all

@tnqn tnqn merged commit a262fc9 into antrea-io:main Apr 10, 2024
49 of 52 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
action/release-note Indicates a PR that should be included in release notes. kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants