-
Notifications
You must be signed in to change notification settings - Fork 359
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove deprecated v1alpha1/ExternalEntity #6177
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Can we track down when we stopped serving the API an update docs/api.md accordingly? |
Sure, I will update the Doc. |
67574db
to
c3f2c79
Compare
docs/api.md
Outdated
@@ -81,3 +81,4 @@ These are the API group versions which are currently available when using Antrea | |||
| CRD | CRD version | Introduced in | Deprecated in | Removed in | | |||
|---|---|---|---|---| | |||
| `ClusterGroup` | v1alpha2 | v1.0.0 | v1.1.0 | v2.0.0 | | |||
| `ExternalEntity` | v1alpha1 | v0.10.0 | v1.7.0 | v2.0.0 | |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This was actually deprecated in v0.11.0 by #1467
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed, thanks for the reminder.
v1alpha1/ExternalEntity is not served for a long time, so it can be removed from the CRD definition. Signed-off-by: hjiajing <hjiajing@vmware.com>
c3f2c79
to
1df9603
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
/skip-all |
v1alpha1/ExternalEntity is not served for a long time, so it can be removed from the CRD definition.