-
Notifications
You must be signed in to change notification settings - Fork 359
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Increase the minimum supported Kubernetes version to v1.19 #6089
Conversation
68abc85
to
92255f3
Compare
@@ -44,6 +44,9 @@ spec: | |||
externalNode: | |||
type: string | |||
- name: v1alpha1 | |||
deprecated: true |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There are a few more CRDs with two or more served versions, I think we need to add this field for all old versions. @antoninbas what's your thoughts?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, we have more deprecated CRD versions according to https://github.com/antrea-io/antrea/blob/main/docs/api.md#crds-in-crdantreaio
Looking at this document, I have 2 questions though:
- why is
v1alpha1/ExternalEntity
not listed in the doc? - the doc mentions that
v1alpha1/Tier
is supposed to be removed in Antrea v2.0. Are we still planning to do that?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There are a few more CRDs with two or more served versions, I think we need to add this field for all old versions. @antoninbas what's your thoughts?
Yes, that is what I want to ask. So, if one CRD has more than one served version, we just keep the latest one and add deprecated: true
and deprecation warning to other versions?.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes. https://github.com/antrea-io/antrea/blob/main/docs/api.md#crds-in-crdantreaio should also be up-to-date in that regard (see Deprecated in
column).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Updated.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the reminder, I will rebase after that PR is merged.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I agree, looks like we can simply remove v1alpha1/ExternalEntity
. It has not been served for 2+ years. But let's do it in a separate PR.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @antoninbas , I created a PR to remove this CRD #6177
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks. I assume this PR will need to be rebased after we merge #6177
a8c0dda
to
ff490d0
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM overall, @hjiajing could you check the comment of PR6177, so we can merge it and move forward for this PR? Thanks.
ff490d0
to
dbc87f8
Compare
Hi @luolanzone @antoninbas , I have rebased to the latest main branch, could you please help to check this PR, thanks. |
dbc87f8
to
06ca2d0
Compare
deprecated: true | ||
deprecationWarning: "crd.antrea.io/v1alpha1 ClusterNetworkPolicy is deprecated; use crd.antrea.io/v1beta1 ClusterNetworkPolicy" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this API (and some other ones) were supposed to be removed in #6162
I think @luolanzone may have missed some files when updating her PR
I will open a PR to address this
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since Kubernetes v1.19, some APIs are deprecated. Add deprecated comment to those APIs and update documents. Reference: https://kubernetes.io/docs/reference/using-api/deprecation-guide/ Signed-off-by: hjiajing <hjiajing@vmware.com>
06ca2d0
to
04d762a
Compare
/skip-all |
Since Kubernetes v1.19, some APIs are deprecated. Add deprecated comment to those APIs and update documents.
Reference: https://kubernetes.io/docs/reference/using-api/deprecation-guide/