Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RI2][pcac]: Correcting document title #3116

Merged
merged 2 commits into from
Oct 26, 2022

Conversation

CsatariGergely
Copy link
Collaborator

Based on the discussion in #3045

Based on the discussion in anuket-project#3045

Signed-off-by: Gergely Csatari <gergely.csatari@nokia.com>
Copy link
Collaborator

@gkunz gkunz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am a little torn between the technically correct title "based on RA2 specs" and not having the target platform (Kubernetes) in the title. But I am ok with the proposal.

Co-authored-by: Pankaj Goyal <52107136+pgoyal01@users.noreply.github.com>
@CsatariGergely
Copy link
Collaborator Author

I am a little torn between the technically correct title "based on RA2 specs" and not having the target platform (Kubernetes) in the title. But I am ok with the proposal.

This is why I added the "This is ..." sentence after the title

@pgoyal01 pgoyal01 requested a review from a team August 12, 2022 13:10
@CsatariGergely CsatariGergely added the Merge-Ready Author of PR signals ready for merge (by Code Owner) label Aug 26, 2022
@CsatariGergely CsatariGergely changed the title [RI2]: Correcting document title [RI2][pcac]: Correcting document title Sep 15, 2022
@steelescotr steelescotr self-requested a review September 21, 2022 13:52
Copy link
Collaborator

@steelescotr steelescotr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved

@wmk-admin wmk-admin merged commit db12b5b into anuket-project:master Oct 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Merge-Ready Author of PR signals ready for merge (by Code Owner)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants