Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[root]: Butifying the link list #3045

Merged
merged 9 commits into from
Sep 6, 2022

Conversation

CsatariGergely
Copy link
Collaborator

Closes #3044

Signed-off-by: Gergely Csatari <gergely.csatari@nokia.com>
@collivier
Copy link
Collaborator

Please rebase it (I cannot do it in Nokia's repo) - now gate is successful

@CsatariGergely
Copy link
Collaborator Author

Please rebase it (I cannot do it in Nokia's repo) - now gate is successful

@collivier Done now.

Signed-off-by: Gergely Csatari <gergely.csatari@nokia.com>
doc/index.rst Outdated Show resolved Hide resolved
doc/index.rst Outdated Show resolved Hide resolved
CsatariGergely and others added 2 commits July 1, 2022 13:56
Co-authored-by: Pankaj Goyal <52107136+pgoyal01@users.noreply.github.com>
Co-authored-by: Pankaj Goyal <52107136+pgoyal01@users.noreply.github.com>
@CsatariGergely CsatariGergely requested a review from pgoyal01 July 1, 2022 10:56
doc/index.rst Outdated Show resolved Hide resolved
doc/index.rst Outdated Show resolved Hide resolved
doc/index.rst Outdated Show resolved Hide resolved
doc/index.rst Outdated Show resolved Hide resolved
CsatariGergely and others added 2 commits July 15, 2022 14:55
Co-authored-by: Pankaj Goyal <52107136+pgoyal01@users.noreply.github.com>
Signed-off-by: Gergely Csatari <gergely.csatari@nokia.com>
@CsatariGergely CsatariGergely requested a review from pgoyal01 July 15, 2022 12:06
@gkunz
Copy link
Collaborator

gkunz commented Aug 8, 2022

sorry for the very late comment... If I understand the old solution correctly, Sphinx uses the heading of the index file pointed to for the name of the link. So instead of overwriting the links explicitly here, wouldn't a more consistent approach be to ensure that the headings in the target index files correctly named? Then we'd have the same name in both places instead of overwriting it here and once clicking on it, the heading is different. This can be confusing.

@CsatariGergely
Copy link
Collaborator Author

Yes I agree, that it would be more consistent, but that looks like a multi release project :)
What if we merge this as it is and I create the PR-s to update the target document titles and we gradually remove the overwites from here as the correction PR-s are merged?

@gkunz
Copy link
Collaborator

gkunz commented Aug 9, 2022

@CsatariGergely: that's totally fine with me. Let's separate the concept from the implementation. If we agree to aim for consistency, we can surely gradually update the docs to get there.

@CsatariGergely CsatariGergely added the Merge-Ready Author of PR signals ready for merge (by Code Owner) label Aug 9, 2022
CsatariGergely added a commit to nokia/CNTT that referenced this pull request Aug 11, 2022
Based on the requirement in  anuket-project#3045

Signed-off-by: Gergely Csatari <gergely.csatari@nokia.com>
CsatariGergely added a commit to nokia/CNTT that referenced this pull request Aug 11, 2022
Based on the discussion in anuket-project#3045

Signed-off-by: Gergely Csatari <gergely.csatari@nokia.com>
CsatariGergely added a commit to nokia/CNTT that referenced this pull request Aug 11, 2022
Based on the discussion in anuket-project#3045

Signed-off-by: Gergely Csatari <gergely.csatari@nokia.com>
CsatariGergely added a commit to nokia/CNTT that referenced this pull request Aug 11, 2022
Based on the discussion in anuket-project#3045

Signed-off-by: Gergely Csatari <gergely.csatari@nokia.com>
CsatariGergely added a commit to nokia/CNTT that referenced this pull request Aug 11, 2022
Based on the discussion in anuket-project#3045

Signed-off-by: Gergely Csatari <gergely.csatari@nokia.com>
CsatariGergely added a commit to nokia/CNTT that referenced this pull request Aug 12, 2022
Based on the discussion in anuket-project#3045

Signed-off-by: Gergely Csatari <gergely.csatari@nokia.com>
CsatariGergely added a commit to nokia/CNTT that referenced this pull request Aug 12, 2022
Based on the discussion in anuket-project#3045

Signed-off-by: Gergely Csatari <gergely.csatari@nokia.com>
CsatariGergely added a commit to nokia/CNTT that referenced this pull request Aug 12, 2022
Based on the discussion in anuket-project#3045

Signed-off-by: Gergely Csatari <gergely.csatari@nokia.com>
karinesevilla pushed a commit that referenced this pull request Aug 17, 2022
* [RA1]: Correcting document title

Based on the discussion in #3045

Signed-off-by: Gergely Csatari <gergely.csatari@nokia.com>

* [RA1]: Correcting of the title in conf.py also

Signed-off-by: Gergely Csatari <gergely.csatari@nokia.com>

Signed-off-by: Gergely Csatari <gergely.csatari@nokia.com>
@karinesevilla karinesevilla merged commit 0995f85 into anuket-project:master Sep 6, 2022
collivier pushed a commit that referenced this pull request Sep 7, 2022
* [RA1]: Correcting document title

Based on the discussion in #3045

Signed-off-by: Gergely Csatari <gergely.csatari@nokia.com>

* [RA1]: Correcting of the title in conf.py also

Signed-off-by: Gergely Csatari <gergely.csatari@nokia.com>

Signed-off-by: Gergely Csatari <gergely.csatari@nokia.com>
(cherry picked from commit f66105a)
wmk-admin pushed a commit that referenced this pull request Sep 9, 2022
* [RM]: Correcting document title

Based on the requirement in  #3045

Signed-off-by: Gergely Csatari <gergely.csatari@nokia.com>

* [RM]: Minor correction in the title

Signed-off-by: Gergely Csatari <gergely.csatari@nokia.com>

* [RM]: Adding Cloud Infrastructure to the title

Signed-off-by: Gergely Csatari <gergely.csatari@nokia.com>

Signed-off-by: Gergely Csatari <gergely.csatari@nokia.com>
collivier pushed a commit that referenced this pull request Sep 12, 2022
* [RC2]: Correcting the title of the document

Based on the discussion in #3045

Signed-off-by: Gergely Csatari <gergely.csatari@nokia.com>

* Update doc/ref_cert/RC2/index.rst

Co-authored-by: Pankaj Goyal <52107136+pgoyal01@users.noreply.github.com>

Signed-off-by: Gergely Csatari <gergely.csatari@nokia.com>
Co-authored-by: Pankaj Goyal <52107136+pgoyal01@users.noreply.github.com>
walterkozlowski pushed a commit that referenced this pull request Sep 21, 2022
* [RA2]: Correcting document title

Based on the discussion in #3045

Signed-off-by: Gergely Csatari <gergely.csatari@nokia.com>

* Update doc/ref_arch/kubernetes/conf.py

Co-authored-by: Riccardo Gasparetto Stori <4398095+rgstori@users.noreply.github.com>

Signed-off-by: Gergely Csatari <gergely.csatari@nokia.com>
Co-authored-by: Riccardo Gasparetto Stori <4398095+rgstori@users.noreply.github.com>
wmk-admin pushed a commit that referenced this pull request Oct 26, 2022
* [RI1]: Correcting document title

Based on the discussion in #3045

Signed-off-by: Gergely Csatari <gergely.csatari@nokia.com>

* [RI1]: Clarifying the intro sentence

Signed-off-by: Gergely Csatari <gergely.csatari@nokia.com>

Signed-off-by: Gergely Csatari <gergely.csatari@nokia.com>
wmk-admin pushed a commit that referenced this pull request Oct 26, 2022
* [RI2]: Correcting document title

Based on the discussion in #3045

Signed-off-by: Gergely Csatari <gergely.csatari@nokia.com>

* Update doc/ref_impl/cntt-ri2/index.rst

Co-authored-by: Pankaj Goyal <52107136+pgoyal01@users.noreply.github.com>

Signed-off-by: Gergely Csatari <gergely.csatari@nokia.com>
Co-authored-by: Pankaj Goyal <52107136+pgoyal01@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Merge-Ready Author of PR signals ready for merge (by Code Owner)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[root]: Add a single intro link instead of links to chapter in the root of the Anuket specs
9 participants