Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove SBF_JMP32 instruction class #80

Merged
merged 2 commits into from
Jan 15, 2024

Conversation

LucasSte
Copy link
Collaborator

@LucasSte LucasSte commented Jan 10, 2024

Although the instruction class SBF_JMP32 = 0x06 exists in the upstream BPF target, it is absent in Solana's RBPF crate, and the code 0x06 has been repurposed for a new instruction class PQR in solana-labs/rbpf#498.

This PR removes all instructions related to the class SBF_JMP32.

@LucasSte LucasSte changed the title Remove SBF_JMP32 class Remove SBF_JMP32 instruction class Jan 10, 2024
@LucasSte LucasSte marked this pull request as ready for review January 10, 2024 21:37
Copy link
Collaborator

@dmakarov dmakarov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, except a couple of formatting nits.

llvm/lib/Target/SBF/SBFISelLowering.cpp Outdated Show resolved Hide resolved
llvm/test/CodeGen/SBF/atomics_sbf.ll Outdated Show resolved Hide resolved
@LucasSte LucasSte merged commit 5348da2 into anza-xyz:solana-rustc/16.0-2023-06-05 Jan 15, 2024
14 checks passed
@LucasSte LucasSte deleted the pqr-p1 branch January 15, 2024 17:43
LucasSte added a commit to LucasSte/llvm-project that referenced this pull request Jan 31, 2024
LucasSte added a commit that referenced this pull request Feb 16, 2024
LucasSte added a commit to LucasSte/llvm-project that referenced this pull request Jun 28, 2024
LucasSte added a commit that referenced this pull request Aug 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants