This repository has been archived by the owner on Feb 13, 2021. It is now read-only.
Release/1.20.0 #4
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
prebid#1011) * added support for sampling in ga and base adapter, fixed some tests * added ability to pipe analytics events to customize values before logging * don't mutate original args in analytics adapter pipe function * remove pipe functionality in favor of custom adapter implementation * fixed bug in GA adapter looking for property on potential non-object
* added pr review process and governance model * fixed typo
* Added WideOrbit adapter * Fix User Matching code * Renamed adapter + some minor JS issues * Added flag for notifying front action is header bidding. Use returned bid. * Duplicated properties fixed. * Correcting adaptermanager after wrong merge. Now all tests passes correctly. * Seting fl and jscb directly in the pageImpression-part of the url, since they are hardcoded. * Fixed above the fold parameter * No need to modify original value. * Normalizing file regarding single or double quotes. Also, properly indenting. * Removed uneeded properties: referrer (twice) and tagId. * Slightly better readiblity for variable declarations (and definition in some cases). * Refactoring regarding function naming and the way we set rank parameter. Also making sure we encode/decode site and page parameters. * Ignoring TypeScript's typing definitions. * Added initial WideOrbit Adapter tests covering url-creation part. * Completed wide orbit adapter tests with the one regarding callback response. * Slightly better test names. * Fix support for already prepared tracking pixels * Modified indenting according to coding standard * Code review fixes * Marked required parameters * Remove unused library from package.json Fix unit tests after refactoring * Added support for referrer * Added support for referrer * Updated line endings to UNIX style * Fixed formatting issue * Fix user matching identification for JavaScript type * Duplicated WideOrbit spec after merge * Made adapter more robust for server misconfiguration
…ame (prebid#1066) * allow writing into current document if prebid is loaded inside an iframe * updated tests to use utils.isiFrame instead of doc === window.document * only check doc === document in renderAd if not in iFrame * check for frameElement to prevent error in cross-origin iFrame case
* add yarn.lock file * use yarn registry proxy * update README * link to yarn docs * link to yarn docs again closes RAD-1469
* add roxot adapter * update roxot analytics system * remove unused test * remove unused import * update code after review * add analytic adapter - roxot prebid analytic * Update roxot prebid analytic * update * Fix tests * Fix Roxot tests * Fix endpoint * Register config only once. * Clear ad parameter for optimize traffic * Fix after review * Fix remove ad from global object * Add tests. * Remove request_bids event from AnalyticsAdapter.js * Remove extra dependencies
* Oct 27 Oct 27 * Added Innity Innity Adapter * Innity GPT Test Page * Restore Master pbjs_example_gpt.html * Changes based on jaiminpanchal27 feedback - Align innity in adapters.json - Format innity_spec.js - Add bidRequest into innity.js * Fixed formatting and remove unnecessary code (prebid#1074)
* widespace adapter: separating params with # and addding hb, and hb.ver into it * widespace adapter: update tests with new mandatory params * widespace adapter: add adapter version number before # so we can force specific cached request script based on our adapter version * widespace adapter: sid as query param * widespace adapter: revert back sid after hash
* init * refactoring and replacing hard-coded variables * changed error handling if missing adid or bidfloor * created testing spec for beachfront adapter & began writing unit tests * working on testing * still testing * all tests passing but the last two. Almost there... * getting ready to change to new getmu response * adapter working, tests complete; removing console logs and setting up for prebid.js pull request * only the beachfront adapter plus prebidvid.html * merging with upstream master * Added adapter for Beachfront and associated tests. * updating adapter * Ready for pull request with prebid.js * Updated ‘dev’ parameter in test request * Update params for pull request * Pointing to prod endpoint in adapter and test * Stage adapter files for prebid pull request * Retrying commit of adapter files for PR * last-minute * Made updates requested for PR * Removed console logs and bid counter * Updates for test * Updated master branch, added index.html for testing * added check for bidfloor and return on undefined rtbdataparams * Deleted index.html * updated newBid.bidId
Size selection moved to server side. Changed API parameters accordingly: `selectedSize` will simply be the first size in the sizes array `placementSizes` -> `additionalSizes` and includes sizes besides the first one Removed adapter parameters: - allowedSize - sizeTolerance
* Adding AdButler Adapter * Prevent AdButler TypeError Only attempt to build a bid response if we have the information of which bid to respond to. * Refactor AdButler Testing Now stubbing adLoader instead of spying. Additional changes to ensure all tests still passed. * Prevent AdButler TypeErrors Prevent AdButler TypeErrors and pass bid request object into the bid response. * Add optional domain parameter. Add optional domain parameter to AdButler adapter.
* add renderer adapter type initial appnexus outstream renderer adapter * render outstream response from appnexus * trim back to steel thread * turn off istanbul * fix adUrl, move mediaType logical test * clean up * load renderer in renderAd * clean up * fix loadScript in render RAD-1439 * collapse divs on render * add Renderer class, remove render functions from prebid.js file * wip * add API to Renderer to set render function and event handlers cache loadScript for renderer Renderer.install returns existing instance of renderer, if available * add support for multiple video units, renderer options can be set from bid level data * example page edits * decruftification * import utils with es syntax * add tests * add tests * use .call instead of .bind, reduce auction time limit on example * use mock server for tests on Renderer.install * fix test * appease Travis * appease Travis some more * appease Travis some more again * outstream example create utility functions for readability * test link to use public endpoint * remove prebid key from example ad server targeting * reorder code in bidder * review notes * fix test
* Catch uncaught parse error causing test failures * Return in catch clause
* create adapter huddledmasses * Trigger for current build rerun on Travis CI due to gulp installation failure on testing instance * Trigger for current build rerun on Travis CI due to npm-install issues on testing instance
* Adding a new Trion Interactive Adapter and associated tests to prebid. * adding pub and section id grab before user sync is called
Mocha redefines `window.context` so the `isAmp` function in the Mantis adapter doesn't work as expected under test. Commenting test out for now.
temporary workaround, issue to be created for follow up
Babel transpilation of `for...of` is depending on the presence of `Symbol` which breaks in IE11 and other IE. This fix is a temporary workaround and an issue will be created for follow up with adapter maintainers.
Babel transpilation of `for...of` is depending on the presence of `Symbol` which breaks in IE11 and other IE. This fix is a temporary workaround and an issue will be created for follow up with adapter maintainers.
This is a temporary workaround to address build issues and will an issue will be created to follow up with adapter maintainers.
Temporary workaround as the test url now redirects to a different domain. An issue will be created for follow up by adapter maintainers.
This was causing an error to be thrown in console and reported as error from IE under Browserstack unit test
Fixes script errors in IE Browserstack tests. This still throws a network error and needs to be silenced along with the many others.
…e/Prebid-official-0.22.2 # Conflicts: # src/adapters/sharethrough.js
…20.0 to aolgithub-master * commit '80a37975d00dadcb5b3e995e26b6fe0a0435f873': (42 commits) Updated build status indicator. Added adapters in aolPartnersIds.json. Added changelog entry. Prebid 0.22.2 Release Renderer test - use httpbin/post endpoint in place of domain alone AdKernal - comment out console.warn in test WideOrbit - remove test referencing url with redirect add karma-es5-shim again via yarn Widespace - fix lint error on build and test Fix Object.assign support for IE11 & < Widespace - use forEach in place of for...of Underdogmedia - use forEach in place of for...of PlusepointLite - comment out breaking tests Prebid 0.22.1 Release set babel plugins @6.22.0 lock down babel packages @6.24.1 PulsePointLite: comment out breaking adapter test Prebid 0.22.0 Release Update polyfills to use core-js. (prebid#1142) Mantis - comment out breaking test ...
vzhukovsky
pushed a commit
that referenced
this pull request
May 28, 2018
* Convert Criteo adapter to bidderFactory * Add documentation for Prebid 1.0 Criteo adapter * Add support for zone-matching bids on Prebid 1.0 Criteo adapter * Add unit tests to the Prebid 1.0 Criteo adapter * Explicit the fact that Criteo bids are net revenue * Pass currency in Criteo 1.0 adapter * Update Criteo adapter to use PublisherTag if present * Implement fastbid in prebid 1.0 criteo adapter * Pass the bid requests to the Criteo interpret method * Add missing ttl and creativeId fields to Criteo bids * Add 'native' support to the Criteo adapter * Check that the Criteo adapter returned by PublisherTag is not empty * Update criteo prebid adapter to reload publisher tag once auction is finished * Fix 'assign to const' IE errors in Criteo native adapter * Disable the PublisherTag event queue * Fix Criteo adapter on older Prebid versions not using response.body * Fix TypeError if FastBid is outdated * Remove the success variable in tryGetCriteoFastBid * Fix events being overwritten with FastBid * Update PublisherTag loading comment * Use adUnitCode as impid * Add events handlers in Criteo adapter to fix timeouts not treated as such * Add handler for setTargeting event * Move the registeredEvents set higher up to reduce the chances of race conditions * Fix UTests following recent Criteo adapter changes * Add comment linking to the PublisherTag unminified source * Do not return a request in buildRequests on error In some cases, the buildCdbRequest function might return a falsy value, in case of error in creating the request or if we know in advance that this request will return a no-bid. In this case, the buildRequests() method should not return a request, causing a no-bid. * Use loadExternalScript instead of loadScript * Use spec.onTimeout instead of registering an event handler * GDPR support in Criteo adapter (#4) GDPR support in Criteo adapter * Remove BID_WON and SET_TARGETING events from Criteo adapter * Update adapter version * Add support for multi-size in Criteo adapter * Fix support for multi size in Criteo adapter * Update adapterVersion to 7
vzhukovsky
pushed a commit
that referenced
this pull request
May 28, 2018
…ad of default false value when values are not defined (prebid#2630) * Convert Criteo adapter to bidderFactory * Add documentation for Prebid 1.0 Criteo adapter * Add support for zone-matching bids on Prebid 1.0 Criteo adapter * Add unit tests to the Prebid 1.0 Criteo adapter * Explicit the fact that Criteo bids are net revenue * Pass currency in Criteo 1.0 adapter * Update Criteo adapter to use PublisherTag if present * Implement fastbid in prebid 1.0 criteo adapter * Pass the bid requests to the Criteo interpret method * Add missing ttl and creativeId fields to Criteo bids * Add 'native' support to the Criteo adapter * Check that the Criteo adapter returned by PublisherTag is not empty * Update criteo prebid adapter to reload publisher tag once auction is finished * Fix 'assign to const' IE errors in Criteo native adapter * Disable the PublisherTag event queue * Fix Criteo adapter on older Prebid versions not using response.body * Fix TypeError if FastBid is outdated * Remove the success variable in tryGetCriteoFastBid * Fix events being overwritten with FastBid * Update PublisherTag loading comment * Use adUnitCode as impid * Add events handlers in Criteo adapter to fix timeouts not treated as such * Add handler for setTargeting event * Move the registeredEvents set higher up to reduce the chances of race conditions * Fix UTests following recent Criteo adapter changes * Add comment linking to the PublisherTag unminified source * Do not return a request in buildRequests on error In some cases, the buildCdbRequest function might return a falsy value, in case of error in creating the request or if we know in advance that this request will return a no-bid. In this case, the buildRequests() method should not return a request, causing a no-bid. * Use loadExternalScript instead of loadScript * Use spec.onTimeout instead of registering an event handler * GDPR support in Criteo adapter (#4) GDPR support in Criteo adapter * Remove BID_WON and SET_TARGETING events from Criteo adapter * Update adapter version * Add support for multi-size in Criteo adapter * Fix support for multi size in Criteo adapter * Update adapterVersion to 7 * GDPR support criteo: send undefined gdpr consent fields instead of false when not defined * Update adapterVersion to 8
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of change
Description of change
Other information