This repository has been archived by the owner on Dec 10, 2021. It is now read-only.
fix(plugin-chart-echarts): enable animation to clear old nodes #1200
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🐛 Bug Fix
Due to a bug present in ECharts 5.1.2, Treemap doesn't properly rerender when the option changes when animation is disabled (see apache/echarts#15282 for details). Until the fix apache/echarts#15283 is merged and released, we should enable animations to work around the bug. I also consider the animation pretty nice, so I wouldn't mind leaving animations enabled.
In addition, the color scheme is changed to reference the group name, aligning it with colors in other charts in the dashboard.
AFTER
treemap-after2.mp4
BEFORE
treemap-before.mp4