Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(treemap): remove old nodes on disabled animation #15283

Merged
merged 2 commits into from
Jul 3, 2021

Conversation

villebro
Copy link
Member

@villebro villebro commented Jul 2, 2021

When animation is set to false on treemap, renderFinally() isn't called when calling setOption for the second time.

Brief Information

This pull request is in the type of:

  • bug fixing
  • new feature
  • others

What does this PR do?

This PR makes sure renderFinally() is always called even if animation is disabled.

Fixed issues

Details

Before: What was the problem?

In this screenshot, Alexia and Beth should have been removed (they were present in the first option, but were removed in the second option):
image

After: How is it fixed in this PR?

After the change, the names are removed correctly when calling setOption again.
image

Merging options

  • Please squash the commits into a single one when merge.

Other information

@echarts-bot
Copy link

echarts-bot bot commented Jul 2, 2021

Thanks for your contribution!
The community will review it ASAP. In the meanwhile, please checkout the coding standard and Wiki about How to make a pull request.

The pull request is marked to be PR: author is committer because you are a committer of this project.

@villebro villebro reopened this Jul 2, 2021
@pissang pissang requested a review from 100pah July 3, 2021 01:13
@pissang pissang added this to the 5.2 milestone Jul 3, 2021
@pissang pissang merged commit 2cf55e9 into apache:master Jul 3, 2021
@echarts-bot
Copy link

echarts-bot bot commented Jul 3, 2021

Congratulations! Your PR has been merged. Thanks for your contribution! 👍

@villebro villebro deleted the villebro/treemap-animation branch July 5, 2021 06:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Treemap doesn't clear old nodes when animation disabled
2 participants