Skip to content
This repository has been archived by the owner on Dec 10, 2021. It is now read-only.

chore(core): move @emotion/styled to peer dependency #1347

Merged
merged 1 commit into from
Sep 6, 2021

Conversation

villebro
Copy link
Contributor

@villebro villebro commented Sep 6, 2021

🏠 Internal

Move @emotion/styled to peer dependency to fix version conflict on apache/superset. Also bump other @emotion deps to match those in apache/superset#16559

@villebro villebro requested a review from a team as a code owner September 6, 2021 07:02
@vercel
Copy link

vercel bot commented Sep 6, 2021

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/superset/superset-ui/Dr2ao3UQCwKtwabGpfgQRMokbMvo
✅ Preview: https://superset-ui-git-fork-preset-io-villebro-emotion-styled-superset.vercel.app

Copy link
Contributor

@zhaoyongjie zhaoyongjie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codecov
Copy link

codecov bot commented Sep 6, 2021

Codecov Report

Merging #1347 (09932c6) into master (484af3a) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1347   +/-   ##
=======================================
  Coverage   30.03%   30.03%           
=======================================
  Files         489      489           
  Lines        9856     9856           
  Branches     1654     1654           
=======================================
  Hits         2960     2960           
  Misses       6655     6655           
  Partials      241      241           
Impacted Files Coverage Δ
...s/plugin-chart-echarts/src/Gauge/transformProps.ts 83.33% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 484af3a...09932c6. Read the comment docs.

@villebro villebro merged commit 1950479 into apache-superset:master Sep 6, 2021
@villebro villebro deleted the villebro/emotion-styled branch September 6, 2021 08:09
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants