Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: bump emotion to help with cache clobbering #16559

Merged
merged 1 commit into from
Sep 2, 2021
Merged

chore: bump emotion to help with cache clobbering #16559

merged 1 commit into from
Sep 2, 2021

Conversation

eschutho
Copy link
Member

@eschutho eschutho commented Sep 1, 2021

SUMMARY

we were seeing some instances where emotion styling wasn't showing up on sql lab. I think it may be related to this issue: emotion-js/emotion#2209 so I bumped emotion to bring in the patch fix. So far testing looks positive that it fixed the issue.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

Superset

TESTING INSTRUCTIONS

Reload sql lab often- each load should have all the styles.

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@codecov
Copy link

codecov bot commented Sep 1, 2021 •
edited
Loading

Codecov Report

Merging #16559 (658c1a9) into master (02798a3) will increase coverage by 0.52%.
The diff coverage is n/a.

❗ Current head 658c1a9 differs from pull request most recent head 5431f4b. Consider uploading reports for the commit 5431f4b to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##           master   #16559      +/-   ##
==========================================
+ Coverage   76.19%   76.71%   +0.52%     
==========================================
  Files        1002     1002              
  Lines       53813    53801      -12     
  Branches     7287     6858     -429     
==========================================
+ Hits        41005    41276     +271     
+ Misses      12568    12288     -280     
+ Partials      240      237       -3
Flag Coverage Δ
javascript 71.00% <ø> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
superset/db_engines/hive.py 82.14% <0.00%> (-3.05%) ⬇️
superset-frontend/src/views/CRUD/hooks.ts 46.98% <0.00%> (ø)
...end/src/SqlLab/components/RunQueryActionButton.tsx 65.11% <0.00%> (ø)
...end/src/visualizations/FilterBox/transformProps.ts 6.66% <0.00%> (ø)
superset/views/base_api.py 98.31% <0.00%> (+0.42%) ⬆️
superset/utils/core.py 89.89% <0.00%> (+0.48%) ⬆️
superset/security/manager.py 91.84% <0.00%> (+0.52%) ⬆️
superset/db_engine_specs/postgres.py 97.36% <0.00%> (+0.87%) ⬆️
superset/utils/cache.py 74.52% <0.00%> (+0.94%) ⬆️
superset-frontend/src/components/Select/Select.tsx 73.42% <0.00%> (+0.96%) ⬆️
... and 20 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 02798a3...5431f4b. Read the comment docs.

villebro
villebro requested changes Sep 2, 2021
View reviewed changes
Copy link
Member

@villebro villebro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You appear to be on an old version of npm (lock file version is downgraded from 2 to 1 in this PR). Can you make sure you're running npm i on a npm version 7?

@eschutho
Copy link
Member Author

eschutho commented Sep 2, 2021

You appear to be on an old version of npm (lock file version is downgraded from 2 to 1 in this PR). Can you make sure you're running npm i on a npm version 7?

Thanks for catching that @villebro!

villebro
villebro approved these changes Sep 2, 2021
View reviewed changes
Copy link
Member

@villebro villebro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@eschutho eschutho merged commit a0db536 into apache:master Sep 2, 2021
@eschutho eschutho deleted the elizabeth/bump-emotion branch September 2, 2021 20:48
@villebro villebro mentioned this pull request Sep 6, 2021
Merged
villebro pushed a commit to preset-io/superset that referenced this pull request Sep 6, 2021
@eschutho @villebro
bump emotion to help with cache clobbering (apache#16559)
793c027
opus-42 pushed a commit to opus-42/incubator-superset that referenced this pull request Nov 14, 2021
@eschutho
bump emotion to help with cache clobbering (apache#16559)
407d0ab
villebro added a commit that referenced this pull request Nov 15, 2021
@villebro @kgabryje
@michael-s-molina @eschutho @robdiciuccio @betodealmeida @joeADSP @ofekisr @simcha90
feat(explore): adhoc column expressions [ID-3] (#17379)
e2a429b 
* add support for adhoc columns to api and sqla model

* fix some types

* fix duplicates in column names

* fix more lint

* fix schema and dedup

* clean up some logic

* first pass at fixing viz.py

* Add frontend support for adhoc columns

* Add title edit

* Fix showing custom title

* Use column name as default value in sql editor

* fix: Adds a loading message when needed in the Select component (#16531)

* fix(tests): make parquet select deterministic with order by (#16570)

* bump emotion to help with cache clobbering (#16559)

* fix: Support Jinja template functions in global async queries (#16412)

* Support Jinja template functions in async queries

* Pylint

* Add tests for async tasks

* Remove redundant has_request_context check

* fix: impersonate user label/tooltip (#16573)

* docs: update for small typos (#16568)

* feat: Add Aurora Data API engine spec (#16535)

* feat: Add Aurora Data API engine spec

* Fix lint

* refactor: sql_json view endpoint: encapsulate ctas parameters (#16548)

* refactor sql_json view endpoint: encapsulate ctas parameters

* fix failed tests

* fix failed tests and ci issues

* refactor sql_json view endpoint: separate concern into ad hod method (#16595)

* feat: Experimental cross-filter plugins (#16594)

* fix:fix get permission function

* feat: add cross filter chart in charts gallery under FF

* chore(deps): bump superset-ui to 0.18.2 (#16601)

* update type guard references

* fix imports

* update series_columns schema

* Add changes that got lost in rebase

* Use current columns name or expression as sql editor init value

* add integration test and do minor fixes

* Bump superset-ui

* fix linting issue

* bump superset-ui to 0.18.22

* resolve merge conflict

* lint

* fix select filter infinite loop

* bump superset-ui to 0.18.23

* Fix auto setting column popover title

* Enable adhoc columns only if UX_BETA enabled

* put back removed test

* Move popover height and width to constants

* Refactor big ternary expression

Co-authored-by: Kamil Gabryjelski <kamil.gabryjelski@gmail.com>
Co-authored-by: Michael S. Molina <70410625+michael-s-molina@users.noreply.github.com>
Co-authored-by: Elizabeth Thompson <eschutho@gmail.com>
Co-authored-by: Rob DiCiuccio <rob.diciuccio@gmail.com>
Co-authored-by: Beto Dealmeida <roberto@dealmeida.net>
Co-authored-by: joeADSP <75027008+joeADSP@users.noreply.github.com>
Co-authored-by: ofekisr <35701650+ofekisr@users.noreply.github.com>
Co-authored-by: simcha90 <56388545+simcha90@users.noreply.github.com>
QAlexBall pushed a commit to QAlexBall/superset that referenced this pull request Dec 28, 2021
@eschutho
bump emotion to help with cache clobbering (apache#16559)
a90617f
AAfghahi pushed a commit that referenced this pull request Jan 10, 2022
@villebro @kgabryje
@michael-s-molina @eschutho @robdiciuccio @betodealmeida @joeADSP @ofekisr @simcha90 @AAfghahi
feat(explore): adhoc column expressions [ID-3] (#17379)
cdeec15 
* add support for adhoc columns to api and sqla model

* fix some types

* fix duplicates in column names

* fix more lint

* fix schema and dedup

* clean up some logic

* first pass at fixing viz.py

* Add frontend support for adhoc columns

* Add title edit

* Fix showing custom title

* Use column name as default value in sql editor

* fix: Adds a loading message when needed in the Select component (#16531)

* fix(tests): make parquet select deterministic with order by (#16570)

* bump emotion to help with cache clobbering (#16559)

* fix: Support Jinja template functions in global async queries (#16412)

* Support Jinja template functions in async queries

* Pylint

* Add tests for async tasks

* Remove redundant has_request_context check

* fix: impersonate user label/tooltip (#16573)

* docs: update for small typos (#16568)

* feat: Add Aurora Data API engine spec (#16535)

* feat: Add Aurora Data API engine spec

* Fix lint

* refactor: sql_json view endpoint: encapsulate ctas parameters (#16548)

* refactor sql_json view endpoint: encapsulate ctas parameters

* fix failed tests

* fix failed tests and ci issues

* refactor sql_json view endpoint: separate concern into ad hod method (#16595)

* feat: Experimental cross-filter plugins (#16594)

* fix:fix get permission function

* feat: add cross filter chart in charts gallery under FF

* chore(deps): bump superset-ui to 0.18.2 (#16601)

* update type guard references

* fix imports

* update series_columns schema

* Add changes that got lost in rebase

* Use current columns name or expression as sql editor init value

* add integration test and do minor fixes

* Bump superset-ui

* fix linting issue

* bump superset-ui to 0.18.22

* resolve merge conflict

* lint

* fix select filter infinite loop

* bump superset-ui to 0.18.23

* Fix auto setting column popover title

* Enable adhoc columns only if UX_BETA enabled

* put back removed test

* Move popover height and width to constants

* Refactor big ternary expression

Co-authored-by: Kamil Gabryjelski <kamil.gabryjelski@gmail.com>
Co-authored-by: Michael S. Molina <70410625+michael-s-molina@users.noreply.github.com>
Co-authored-by: Elizabeth Thompson <eschutho@gmail.com>
Co-authored-by: Rob DiCiuccio <rob.diciuccio@gmail.com>
Co-authored-by: Beto Dealmeida <roberto@dealmeida.net>
Co-authored-by: joeADSP <75027008+joeADSP@users.noreply.github.com>
Co-authored-by: ofekisr <35701650+ofekisr@users.noreply.github.com>
Co-authored-by: simcha90 <56388545+simcha90@users.noreply.github.com>
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 1.4.0 labels Mar 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@villebro villebro villebro approved these changes

@betodealmeida betodealmeida betodealmeida approved these changes

Assignees
No one assigned
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels preset-io size/XS 🚢 1.4.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@eschutho @betodealmeida @villebro @mistercrunch