This repository has been archived by the owner on Dec 10, 2021. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 272
feat: align metrics title to the right #721
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/superset/superset-ui/bo9xjt55e |
ktmud
force-pushed
the
table-metric-align-right
branch
from
August 4, 2020 18:52
835392b
to
41245b8
Compare
Codecov Report
@@ Coverage Diff @@
## master #721 +/- ##
==========================================
- Coverage 24.19% 24.15% -0.05%
==========================================
Files 339 338 -1
Lines 7617 7606 -11
Branches 925 921 -4
==========================================
- Hits 1843 1837 -6
+ Misses 5701 5698 -3
+ Partials 73 71 -2
Continue to review full report at Codecov.
|
kristw
approved these changes
Aug 4, 2020
6 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🏆 Enhancements
Align table headers for numeric metrics to the right, just like metric values themselves. Fixes #714.
This isn't necessarily the behavior all users want, but is the recommendations of many design guidelines. The plan is to provide a way for users to customize this in the future.
Before
After