Skip to content
This repository has been archived by the owner on Dec 10, 2021. It is now read-only.

feat: align metrics title to the right #721

Merged
merged 4 commits into from
Aug 4, 2020

Conversation

ktmud
Copy link
Contributor

@ktmud ktmud commented Aug 3, 2020

🏆 Enhancements

Align table headers for numeric metrics to the right, just like metric values themselves. Fixes #714.

This isn't necessarily the behavior all users want, but is the recommendations of many design guidelines. The plan is to provide a way for users to customize this in the future.

Before

image

After

image

@ktmud ktmud requested a review from a team as a code owner August 3, 2020 05:53
@vercel
Copy link

vercel bot commented Aug 3, 2020

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/superset/superset-ui/bo9xjt55e
✅ Preview: https://superset-ui-git-fork-ktmud-table-metric-align-right.superset.vercel.app

@ktmud ktmud force-pushed the table-metric-align-right branch from 835392b to 41245b8 Compare August 4, 2020 18:52
@vercel vercel bot temporarily deployed to Preview August 4, 2020 18:52 Inactive
@codecov
Copy link

codecov bot commented Aug 4, 2020

Codecov Report

Merging #721 into master will decrease coverage by 0.04%.
The diff coverage is 60.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #721      +/-   ##
==========================================
- Coverage   24.19%   24.15%   -0.05%     
==========================================
  Files         339      338       -1     
  Lines        7617     7606      -11     
  Branches      925      921       -4     
==========================================
- Hits         1843     1837       -6     
+ Misses       5701     5698       -3     
+ Partials       73       71       -2     
Impacted Files Coverage Δ
plugins/plugin-chart-table/src/TableChart.tsx 55.69% <55.55%> (-0.15%) ⬇️
...ins/plugin-chart-table/src/DataTable/DataTable.tsx 47.61% <100.00%> (+0.39%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b906b24...6e80e77. Read the comment docs.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants