Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(table-viz): translation and metric column header align right #10549

Merged
merged 1 commit into from
Aug 11, 2020

Conversation

ktmud
Copy link
Member

@ktmud ktmud commented Aug 7, 2020

SUMMARY

Upgrade table chart to bring in two changes:

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

Before

image

After

image

TEST PLAN

Manual verify

ADDITIONAL INFORMATION

  • Has associated issue:
  • Changes UI
  • Requires DB Migration.
  • Confirm DB Migration upgrade and downgrade tested.
  • Introduces new feature or API
  • Removes existing feature or API

@codecov-commenter
Copy link

codecov-commenter commented Aug 7, 2020

Codecov Report

❗ No coverage uploaded for pull request base (master@a37b635). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master   #10549   +/-   ##
=========================================
  Coverage          ?   59.15%           
=========================================
  Files             ?      354           
  Lines             ?    22853           
  Branches          ?        0           
=========================================
  Hits              ?    13519           
  Misses            ?     9334           
  Partials          ?        0           
Flag Coverage Δ
#python 59.15% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a37b635...d7eade3. Read the comment docs.

@ktmud ktmud mentioned this pull request Aug 11, 2020
6 tasks
@ktmud ktmud requested review from etr2460 and kristw August 11, 2020 07:59
@ktmud ktmud merged commit 1b111b6 into apache:master Aug 11, 2020
Ofeknielsen pushed a commit to ofekisr/incubator-superset that referenced this pull request Oct 5, 2020
auxten pushed a commit to auxten/incubator-superset that referenced this pull request Nov 20, 2020
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 0.38.0 labels Mar 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/XS 🚢 0.38.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants