Skip to content
This repository has been archived by the owner on Dec 10, 2021. It is now read-only.

feat: implement ECharts pie chart #772

Merged
merged 7 commits into from
Sep 10, 2020

Conversation

villebro
Copy link
Contributor

@villebro villebro commented Sep 4, 2020

🏆 Enhancements
Implement ECharts Pie Chart with same controls as legacy Pie Chart.

Needs to be rebased once superset-ui/core@0.15.0 lands in superset-frontend.

AFTER

image

BEFORE

image

CHART OPTIONS

pie_anim

@vercel
Copy link

vercel bot commented Sep 4, 2020

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/superset/superset-ui/74wiaqxl7
✅ Preview: https://superset-ui-git-fork-preset-io-villebro-echarts-pie.superset.vercel.app

@vercel vercel bot temporarily deployed to Preview September 7, 2020 11:51 Inactive
@ktmud
Copy link
Contributor

ktmud commented Sep 9, 2020

Wow, looks so much nicer!

@villebro
Copy link
Contributor Author

villebro commented Sep 9, 2020

@ktmud @rusackas this now works with 0.15 and is ready for re-review

Copy link
Contributor

@ktmud ktmud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with some nits

plugins/plugin-chart-echarts/src/Pie/index.ts Outdated Show resolved Hide resolved
plugins/plugin-chart-echarts/src/Pie/transformProps.ts Outdated Show resolved Hide resolved
plugins/plugin-chart-echarts/src/Pie/transformProps.ts Outdated Show resolved Hide resolved
plugins/plugin-chart-echarts/src/Pie/transformProps.ts Outdated Show resolved Hide resolved
plugins/plugin-chart-echarts/src/utils/formatters.ts Outdated Show resolved Hide resolved
plugins/plugin-chart-echarts/src/Pie/controlPanel.ts Outdated Show resolved Hide resolved
plugins/plugin-chart-echarts/src/Pie/controlPanel.ts Outdated Show resolved Hide resolved
plugins/plugin-chart-echarts/src/Pie/controlPanel.ts Outdated Show resolved Hide resolved
plugins/plugin-chart-echarts/src/Pie/controlPanel.ts Outdated Show resolved Hide resolved
@codecov
Copy link

codecov bot commented Sep 10, 2020

Codecov Report

Merging #772 into master will increase coverage by 0.27%.
The diff coverage is 73.52%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #772      +/-   ##
==========================================
+ Coverage   24.89%   25.17%   +0.27%     
==========================================
  Files         353      353              
  Lines        7837     7866      +29     
  Branches     1009     1026      +17     
==========================================
+ Hits         1951     1980      +29     
+ Misses       5783     5777       -6     
- Partials      103      109       +6     
Impacted Files Coverage Δ
...lugins/plugin-chart-echarts/src/Pie/EchartsPie.tsx 0.00% <ø> (ø)
...ugins/plugin-chart-echarts/src/Pie/controlPanel.ts 100.00% <ø> (ø)
plugins/plugin-chart-echarts/src/Pie/index.ts 0.00% <ø> (-33.34%) ⬇️
.../plugin-chart-echarts/src/Timeseries/buildQuery.ts 50.00% <ø> (+16.66%) ⬆️
...ugins/plugin-chart-echarts/src/Timeseries/index.ts 0.00% <ø> (-33.34%) ⬇️
...gin-chart-echarts/src/Timeseries/transformProps.ts 25.53% <ø> (ø)
...ins/plugin-chart-echarts/src/Pie/transformProps.ts 73.68% <72.72%> (+73.68%) ⬆️
plugins/plugin-chart-echarts/src/utils/series.ts 75.00% <100.00%> (+3.57%) ⬆️
plugins/plugin-chart-echarts/src/Pie/buildQuery.ts 100.00% <0.00%> (+100.00%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 79dda3e...53c2d8b. Read the comment docs.

@villebro
Copy link
Contributor Author

@ktmud @rusackas ready for round 2.

Copy link
Member

@rusackas rusackas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for all the follow through on this @villebro and @ktmud. Looking good!

@ktmud ktmud merged commit 3a8b403 into apache-superset:master Sep 10, 2020
@villebro villebro deleted the villebro/echarts-pie branch September 11, 2020 03:53
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants