feat: add ECharts Pie chart #10966
Merged
feat: add ECharts Pie chart #10966
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
they look awesome!!thank you Ville! |
villebro
force-pushed
the
villebro/bump-superset-ui-0.15.3
branch
from
f2a4b9b to
f245670
Compare
villebro
changed the title
villebro
commented
Sep 19, 2020
Comment on lines
-1389
to
-1443
| class TestDistributionPieViz(SupersetTestCase): | ||
| base_df = pd.DataFrame( | ||
| data={ | ||
| "intcol": [1, 2, 3, 4, None], | ||
| "floatcol": [1.0, 0.2, 0.3, 0.4, None], | ||
| "strcol_a": ["a", "a", "a", "a", None], | ||
| "strcol": ["a", "b", "c", None, "d"], | ||
| } | ||
| ) | ||
|
|
||
| @staticmethod | ||
| def get_cols(data: List[Dict[str, Any]]) -> Set[str]: | ||
| return set([row["x"] for row in data]) | ||
|
|
||
| def test_bool_groupby(self): | ||
| datasource = self.get_datasource_mock() | ||
| df = pd.DataFrame(data={"intcol": [1, 2, None], "boolcol": [True, None, False]}) | ||
|
|
||
| pie_viz = viz.DistributionPieViz( | ||
| datasource, {"metrics": ["intcol"], "groupby": ["boolcol"]}, | ||
| ) | ||
| data = pie_viz.get_data(df) | ||
| assert self.get_cols(data) == {"True", "False", "<NULL>"} | ||
|
|
||
| def test_string_groupby(self): | ||
| datasource = self.get_datasource_mock() | ||
| pie_viz = viz.DistributionPieViz( | ||
| datasource, {"metrics": ["floatcol"], "groupby": ["strcol"]}, | ||
| ) | ||
| data = pie_viz.get_data(self.base_df) | ||
| assert self.get_cols(data) == {"<NULL>", "a", "b", "c", "d"} | ||
|
|
||
| def test_int_groupby(self): | ||
| datasource = self.get_datasource_mock() | ||
| pie_viz = viz.DistributionPieViz( | ||
| datasource, {"metrics": ["floatcol"], "groupby": ["intcol"]}, | ||
| ) | ||
| data = pie_viz.get_data(self.base_df) | ||
| assert self.get_cols(data) == {"<NULL>", "1", "2", "3", "4"} | ||
|
|
||
| def test_float_groupby(self): | ||
| datasource = self.get_datasource_mock() | ||
| pie_viz = viz.DistributionPieViz( | ||
| datasource, {"metrics": ["intcol"], "groupby": ["floatcol"]}, | ||
| ) | ||
| data = pie_viz.get_data(self.base_df) | ||
| assert self.get_cols(data) == {"<NULL>", "1", "0.2", "0.3", "0.4"} | ||
|
|
||
| def test_multi_groupby(self): | ||
| datasource = self.get_datasource_mock() | ||
| pie_viz = viz.DistributionPieViz( | ||
| datasource, {"metrics": ["floatcol"], "groupby": ["intcol", "strcol"]}, | ||
| ) | ||
| data = pie_viz.get_data(self.base_df) | ||
| assert self.get_cols(data) == {"1, a", "2, b", "3, c", "4, <NULL>", "<NULL>, d"} |
There was a problem hiding this comment.
Codecov Report
@@ Coverage Diff @@
## master #10966 +/- ##
==========================================
- Coverage 65.80% 65.69% -0.11%
==========================================
Files 815 815
Lines 38327 38304 -23
Branches 3600 3600
==========================================
- Hits 25221 25165 -56
- Misses 13002 13032 +30
- Partials 104 107 +3
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
villebro
force-pushed
the
villebro/bump-superset-ui-0.15.3
branch
4 times, most recently
from
9c28b84 to
fa3ec04
Compare
villebro
force-pushed
the
villebro/bump-superset-ui-0.15.3
branch
from
fa3ec04 to
ba75cdd
Compare
rusackas
approved these changes
Sep 21, 2020
There was a problem hiding this comment.
Fantastic! Happy to see more of viz.py go away, and this first drop-in replacement for NVD3! And tests in the more sensible place! So many good things happening here.
@ktmud / @kristw Please double check that this PR (and ones like it) won't break any use cases you're aware of. I would assume people will be excited to see this one landing though.
pkdotson
approved these changes
Sep 21, 2020
mistercrunch
approved these changes
Sep 22, 2020
|
Thank you! The new pie chart looks so much beautifuler! |
2 tasks
auxten
pushed a commit
to auxten/incubator-superset
that referenced
this pull request
Nov 20, 2020
* feat: introduce echarts pie chart * lint * remove viz.py shim * remove tests * fix cypress test * fix test
|
Roadmap: apache-superset/superset-roadmap#48 |
mistercrunch
added
🏷️ bot
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
Replace the existing NVD3 Pie chart with an ECharts based chart (see apache-superset/superset-ui#772) and bump
superset-uipackages to0.15.3. Also fixes color problems on boxplot and wordcloud.BEFORE
AFTER
TEST PLAN
ADDITIONAL INFORMATION