-
Notifications
You must be signed in to change notification settings - Fork 272
fix(legacy-plugin-chart-pivot-table): pivot table chart string aggregation empty values #880
Conversation
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/superset/superset-ui/7ai9w2ys2 |
Codecov Report
@@ Coverage Diff @@
## master #880 +/- ##
==========================================
+ Coverage 26.58% 26.73% +0.14%
==========================================
Files 380 405 +25
Lines 8192 8248 +56
Branches 1118 1126 +8
==========================================
+ Hits 2178 2205 +27
- Misses 5886 5914 +28
- Partials 128 129 +1
Continue to review full report at Codecov.
|
@mayurnewase this seems to reintroduce displaying of |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A few minor comments, other than that LGTM!
plugins/legacy-plugin-chart-pivot-table/src/utils/formatCells.js
Outdated
Show resolved
Hide resolved
plugins/legacy-plugin-chart-pivot-table/test/PivotTable.test.tsx
Outdated
Show resolved
Hide resolved
plugins/legacy-plugin-chart-pivot-table/src/utils/formatCells.js
Outdated
Show resolved
Hide resolved
@villebro Getting float values from db_engine's cursor.fetchall() for avg(any_string_column),it doesn't seem to be introduced by this pr. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks so much for fixing and improving this code @mayurnewase !
} | ||
} | ||
// @ts-ignore | ||
const attr = ('data-sort', sortAttributeValue); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Eh... I don't think this is a valid JavaScript syntax....
🐛 Bug Fix
Fixes; #868