fix(legacy-plugin-chart-pivot-table): fix displaying image inside rows

[mayurnewase]

🐛 Bug Fix
fixes apache/superset#12681

This ensures text content of cell is only updated if its not empty,as it also overrides innerHtml property of element.

[vercel]

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/superset/superset-ui/bfh4giue3
✅ Preview: https://superset-ui-git-fork-mayurnewase-fix-superset-12681.superset.now.sh

[codecov]

Codecov Report

Merging #954 (a24710a) into master (18f45b6) will decrease coverage by 0.00%.
The diff coverage is 8.33%.

@@            Coverage Diff             @@
##           master     #954      +/-   ##
==========================================
- Coverage   27.67%   27.67%   -0.01%     
==========================================
  Files         401      401              
  Lines        8249     8250       +1     
  Branches     1138     1139       +1     
==========================================
  Hits         2283     2283              
- Misses       5830     5831       +1     
  Partials      136      136              

Impacted Files	Coverage Δ
.../legacy-plugin-chart-pivot-table/src/PivotTable.js	0.00% <0.00%> (ø)
...-plugin-chart-pivot-table/src/utils/formatCells.ts	69.56% <100.00%> (-1.27%)	⬇️
...ckages/superset-ui-chart-controls/src/sections.tsx	100.00% <0.00%> (ø)
...ges/superset-ui-core/src/query/buildQueryObject.ts	100.00% <0.00%> (ø)
.../superset-ui-core/src/query/types/QueryFormData.ts	100.00% <0.00%> (ø)

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 18f45b6...a24710a. Read the comment docs.

[villebro]

Could we rather check for $(this)[0].children.length here? If it's 0 we can assume there are no html tags.

[ktmud]

An easier solution to support the hack in apache/superset#12681 (including hyperlinks) is to check whether cell children is a single text node (this.childNodes.length == 1 && this.childNodes[0].nodeType === Node.TEXT_NODE), and only run formatCellValue if it is.

The assumption is if someone is advanced enough to add HTML to a cell, they are probably OK with not applying d3 formatting to it.

[ktmud]

Check out this branch: https://github.com/apache-superset/superset-ui/compare/pivot-table-fix

It seems sorting on PivotTable is also broken by #880 so I fixed it, too.

[junlincc]

@villebro could you take another look, we need to get the fix out soon. @maloun96 feel free to review any PRs in this repo too. 🙏

@mayurnewase thanks for fixing it!

[ktmud]

LGTM.

@mayurnewase I also added a couple of HTML tests cases with in Storybook. Hope you don't mind.