-
Notifications
You must be signed in to change notification settings - Fork 272
feat(core): copy feature flags from main repo #982
Conversation
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/superset/superset-ui/AXRJA28LB7nV5sTgEER4LM9wMebo |
Codecov Report
@@ Coverage Diff @@
## master #982 +/- ##
=======================================
Coverage 28.10% 28.10%
=======================================
Files 411 412 +1
Lines 8405 8411 +6
Branches 1190 1193 +3
=======================================
+ Hits 2362 2364 +2
- Misses 5890 5894 +4
Partials 153 153
Continue to review full report at Codecov.
|
add6c09
to
3f3a41e
Compare
3f3a41e
to
3f1d0ca
Compare
|
||
describe('isFeatureFlagEnabled', () => { | ||
window.featureFlags = { | ||
[FeatureFlag.CLIENT_CACHE]: true, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nit: flags in tests should probably be test specific because other regular features flags may be eventually cleaned up.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That's a good point, I will address this next time I'm in here
🏆 Enhancements
This copies over the feature flag functionality from
apache/superset
to make it easier to conditionally enable features insuperset-ui
.