Skip to content
This repository has been archived by the owner on Dec 10, 2021. It is now read-only.

feat(core): copy feature flags from main repo #982

Merged
merged 1 commit into from
Mar 1, 2021

Conversation

villebro
Copy link
Contributor

@villebro villebro commented Mar 1, 2021

🏆 Enhancements
This copies over the feature flag functionality from apache/superset to make it easier to conditionally enable features in superset-ui.

@villebro villebro requested a review from a team as a code owner March 1, 2021 10:41
@vercel
Copy link

vercel bot commented Mar 1, 2021

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/superset/superset-ui/AXRJA28LB7nV5sTgEER4LM9wMebo
✅ Preview: https://superset-ui-git-fork-preset-io-villebro-featureflag-superset.vercel.app

@codecov
Copy link

codecov bot commented Mar 1, 2021

Codecov Report

Merging #982 (3f1d0ca) into master (24813c0) will increase coverage by 0.00%.
The diff coverage is 50.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #982   +/-   ##
=======================================
  Coverage   28.10%   28.10%           
=======================================
  Files         411      412    +1     
  Lines        8405     8411    +6     
  Branches     1190     1193    +3     
=======================================
+ Hits         2362     2364    +2     
- Misses       5890     5894    +4     
  Partials      153      153           
Impacted Files Coverage Δ
...et-ui-chart-controls/src/shared-controls/index.tsx 42.55% <0.00%> (ø)
...ackages/superset-ui-core/src/utils/featureFlags.ts 100.00% <100.00%> (ø)
...chart-controls/src/shared-controls/dndControls.tsx 35.29% <0.00%> (-6.38%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 24813c0...3f1d0ca. Read the comment docs.

@ktmud ktmud merged commit bf3091b into apache-superset:master Mar 1, 2021

describe('isFeatureFlagEnabled', () => {
window.featureFlags = {
[FeatureFlag.CLIENT_CACHE]: true,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: flags in tests should probably be test specific because other regular features flags may be eventually cleaned up.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's a good point, I will address this next time I'm in here

@villebro villebro deleted the villebro/featureFlag branch March 4, 2021 11:56
NejcZdovc pushed a commit to blotoutio/superset-ui that referenced this pull request Apr 20, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants