fix: use FeatureFlags in @superset-ui/core

[ktmud]

SUMMARY

Feature flag typing has been added to @superset-ui/core, since there is now two copies of the same typing, sometimes it leads to TS errors when npm link is used or when in Jest.

This change means all future feature flags used in the front-end have to be added to @superset-ui and go through the npm publish process. This is inconvenient but probably necessary to ensure correctness and consistency. Considering we are merging superset-ui to this repo soon, this should not be that much of a problem.

cc @graceguo-supercat @villebro

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

N/A

TEST PLAN

1. npm link ../superset-ui/packages/superset-ui-core
2. npm run type
3. You will see this error in master:

node_modules/@superset-ui/core/src/utils/featureFlags.ts:53:5 - error TS2717: Subsequent property declarations must have the same type.  Property 'featureFlags' must be of type 'FeatureFlagMap', but here has type 'FeatureFlagMap'.

53     featureFlags: FeatureFlagMap;
       ~~~~~~~~~~~~

  src/featureFlags.ts:54:5
    54     featureFlags: FeatureFlagMap;
           ~~~~~~~~~~~~
    'featureFlags' was also declared here.


Found 1 error.

This PR should fix it.

ADDITIONAL INFORMATION

• Has associated issue: feat(core): copy feature flags from main repo apache-superset/superset-ui#982
• Changes UI
• Requires DB Migration.
• Confirm DB Migration upgrade and downgrade tested.
• Introduces new feature or API
• Removes existing feature or API

[codecov]

Codecov Report

Merging #13679 (3391eba) into master (abf2c87) will decrease coverage by 4.01%.
The diff coverage is 50.00%.

❗ Current head 3391eba differs from pull request most recent head 0bf5706. Consider uploading reports for the commit 0bf5706 to get more accurate results

@@            Coverage Diff             @@
##           master   #13679      +/-   ##
==========================================
- Coverage   77.10%   73.08%   -4.02%     
==========================================
  Files         921      611     -310     
  Lines       46745    21695   -25050     
  Branches     5733     5732       -1     
==========================================
- Hits        36043    15856   -20187     
+ Misses      10567     5704    -4863     
  Partials      135      135              

Flag	Coverage Δ
cypress	56.54% <ø> (-0.07%)	⬇️
javascript	63.11% <50.00%> (-0.04%)	⬇️
mysql	?
python	?

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
superset-frontend/src/setup/setupApp.ts	25.00% <0.00%> (ø)
superset-frontend/src/featureFlags.ts	100.00% <100.00%> (ø)
superset-frontend/src/filters/utils.ts	88.88% <0.00%> (-11.12%)	⬇️
superset/views/dashboard/views.py
superset/viz.py
superset/db_engine_specs/oracle.py
superset/databases/schemas.py
superset/utils/urls.py
superset/reports/notifications/__init__.py
... and 304 more

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update abf2c87...0bf5706. Read the comment docs.

[etr2460]

this is a bit inconvenient, but necessary because we moved featureflags into superset-ui and we don't want to change in two places everytime. stamping with one comment

[etr2460]

is this related to the feature flag change? i didn't see how

[ktmud]

It's not, but these globals used to be declared in the featureFlags.ts file. I moved them closer to where they are actually used.