Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added the toFloatList() function #1016

Merged
merged 1 commit into from
Jul 17, 2023
Merged

Added the toFloatList() function #1016

merged 1 commit into from
Jul 17, 2023

Conversation

M4rcxs
Copy link
Contributor

@M4rcxs M4rcxs commented Jul 6, 2023

  • Basically the same function of OpenCypher toFloatList() https://neo4j.com/docs/cypher-manual/current/functions/list/#functions-tofloatlist
  • toFloatList() converts a list of values and returns a list of floating point values. If any values are not convertible to floating point they will be null in the list returned.
  • Returns a list containing the converted elements; depending on the input value a converted value is either a floating point value or null.
  • Also added the regressions tests.

@dehowef
Copy link
Member

dehowef commented Jul 13, 2023

This looks good to me so far upon my first look. Would you mind squashing the commits down into one while maintaining the description? Excellent work.

@M4rcxs
Copy link
Contributor Author

M4rcxs commented Jul 13, 2023

This looks good to me so far upon my first look. Would you mind squashing the commits down into one while maintaining the description? Excellent work.

Thank you!!

@dehowef
Copy link
Member

dehowef commented Jul 13, 2023

Hi, @M4rcxs can you edit the commit title to be descriptive of the changes as well.

- Basically the same function of OpenCypher toFloatList() https://neo4j.com/docs/cypher-manual/current/functions/list/#functions-tofloatlist
- toFloatList() converts a list of values and returns a list of floating point values. If any values are not convertible to floating point they will be null in the list returned.
- Returns a list containing the converted elements; depending on the input value a converted value is either a floating point value or null.
@M4rcxs
Copy link
Contributor Author

M4rcxs commented Jul 14, 2023

Hi, @M4rcxs can you edit the commit title to be descriptive of the changes as well.

I've just done it!

@dehowef
Copy link
Member

dehowef commented Jul 17, 2023

Hello @M4rcxs , the changes look good now and I will merge them shortly~ But, now that we have updated the master branch to PG13, to get these changes into the previous branches, PG11 and PG12, could you create 2 additional pull requests that want to merge into those branches? You can find them in the branch drop down. This goes for all PRs you make here on out (so the ones you made for toIntegerList() as well!) . :) Thanks for contributing and understanding.

@dehowef dehowef merged commit 256df9c into apache:master Jul 17, 2023
6 checks passed
@dehowef
Copy link
Member

dehowef commented Jul 18, 2023

@M4rcxs can you make a PR of this for PG11?

@M4rcxs
Copy link
Contributor Author

M4rcxs commented Jul 19, 2023

@M4rcxs can you make a PR of this for PG11?

Done! did it at #1060

muhammadshoaib pushed a commit to muhammadshoaib/age that referenced this pull request Jul 20, 2023
- Basically the same function of OpenCypher toFloatList() https://neo4j.com/docs/cypher-manual/current/functions/list/#functions-tofloatlist
- toFloatList() converts a list of values and returns a list of floating point values. If any values are not convertible to floating point they will be null in the list returned.
- Returns a list containing the converted elements; depending on the input value a converted value is either a floating point value or null.
@dehowef
Copy link
Member

dehowef commented Jul 20, 2023

@M4rcxs Ty~

MuhammadTahaNaveed pushed a commit to MuhammadTahaNaveed/age that referenced this pull request Aug 24, 2023
- Basically the same function of OpenCypher toFloatList() https://neo4j.com/docs/cypher-manual/current/functions/list/#functions-tofloatlist
- toFloatList() converts a list of values and returns a list of floating point values. If any values are not convertible to floating point they will be null in the list returned.
- Returns a list containing the converted elements; depending on the input value a converted value is either a floating point value or null.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants