Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added the toIntegerList() function #1025

Merged
merged 1 commit into from
Jul 17, 2023
Merged

Conversation

M4rcxs
Copy link
Contributor

@M4rcxs M4rcxs commented Jul 11, 2023

  • This function is inspired by toIntegerList() in OpenCypher.
  • The function toIntegerList() takes a list of values and produces a new list containing only the integer values. If any values cannot be converted to an integer, they will be represented as null in the returned list.
  • The result of the toIntegerList() function is a list that contains the converted elements. The converted values in the list can be either integer values or null, depending on the input value.
  • Also added the regression tests.

@dehowef
Copy link
Member

dehowef commented Jul 14, 2023

@M4rcxs , this fails the regression build. Could you look into why this is occurring? Thanks

- This function is inspired by toIntegerList() in OpenCypher.
- The function toIntegerList() takes a list of values and produces a new list containing only the integer values. If any values cannot be converted to an integer, they will be represented as null in the returned list.
- The result of the toIntegerList() function is a list that contains the converted elements. The converted values in the list can be either integer values or null, depending on the input value.
- Also added the regression tests.
@M4rcxs
Copy link
Contributor Author

M4rcxs commented Jul 14, 2023

@M4rcxs , this fails the regression build. Could you look into why this is occurring? Thanks

@dehowef The error was in the expected part of the regression test, but I fixed it!

@dehowef
Copy link
Member

dehowef commented Jul 17, 2023

Looks good now~, please refer to the message I commented on #1016 Thank you~

@dehowef dehowef merged commit f41f6da into apache:master Jul 17, 2023
6 checks passed
M4rcxs added a commit to M4rcxs/age that referenced this pull request Jul 18, 2023
- This function is inspired by toIntegerList() in OpenCypher.
- The function toIntegerList() takes a list of values and produces a new list containing only the integer values. If any values cannot be converted to an integer, they will be represented as null in the returned list.
- The result of the toIntegerList() function is a list that contains the converted elements. The converted values in the list can be either integer values or null, depending on the input value.
- Also added the regression tests.
muhammadshoaib pushed a commit to muhammadshoaib/age that referenced this pull request Jul 20, 2023
- This function is inspired by toIntegerList() in OpenCypher.
- The function toIntegerList() takes a list of values and produces a new list containing only the integer values. If any values cannot be converted to an integer, they will be represented as null in the returned list.
- The result of the toIntegerList() function is a list that contains the converted elements. The converted values in the list can be either integer values or null, depending on the input value.
- Also added the regression tests.
MuhammadTahaNaveed pushed a commit to MuhammadTahaNaveed/age that referenced this pull request Aug 24, 2023
- This function is inspired by toIntegerList() in OpenCypher.
- The function toIntegerList() takes a list of values and produces a new list containing only the integer values. If any values cannot be converted to an integer, they will be represented as null in the returned list.
- The result of the toIntegerList() function is a list that contains the converted elements. The converted values in the list can be either integer values or null, depending on the input value.
- Also added the regression tests.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants