Fix issue 1124: Segmentation fault when using specific tables #1125
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is a fix for issue 1124 - Segmentation fault when using specific names for tables. This issue is due to an oversight of some very specific types of tables that are parameterless functions. The logic to walk through these nodes didn't expect them and would crash due to them. This fix adds in code to skip over these types of tables. Added regression tests.
|
Looks good to me. |
jrgemignani
added a commit
to jrgemignani/age
that referenced
this pull request
Aug 15, 2023
…#1125) This is a fix for issue 1124 - Segmentation fault when using specific names for tables. This issue is due to an oversight of some very specific types of tables that are parameterless functions. The logic to walk through these nodes didn't expect them and would crash due to them. This fix adds in code to skip over these types of tables. Added regression tests.
dehowef
pushed a commit
that referenced
this pull request
Aug 15, 2023
…#1149) This is a fix for issue 1124 - Segmentation fault when using specific names for tables. This issue is due to an oversight of some very specific types of tables that are parameterless functions. The logic to walk through these nodes didn't expect them and would crash due to them. This fix adds in code to skip over these types of tables. Added regression tests.
jrgemignani
added a commit
to jrgemignani/age
that referenced
this pull request
Aug 15, 2023
…#1125) This is a fix for issue 1124 - Segmentation fault when using specific names for tables. This issue is due to an oversight of some very specific types of tables that are parameterless functions. The logic to walk through these nodes didn't expect them and would crash due to them. This fix adds in code to skip over these types of tables. Added regression tests.
jrgemignani
added a commit
to jrgemignani/age
that referenced
this pull request
Aug 15, 2023
…#1125) This is a fix for issue 1124 - Segmentation fault when using specific names for tables. This issue is due to an oversight of some very specific types of tables that are parameterless functions. The logic to walk through these nodes didn't expect them and would crash due to them. This fix adds in code to skip over these types of tables. Added regression tests.
dehowef
pushed a commit
that referenced
this pull request
Aug 15, 2023
…#1152) This is a fix for issue 1124 - Segmentation fault when using specific names for tables. This issue is due to an oversight of some very specific types of tables that are parameterless functions. The logic to walk through these nodes didn't expect them and would crash due to them. This fix adds in code to skip over these types of tables. Added regression tests.
dehowef
pushed a commit
that referenced
this pull request
Aug 15, 2023
…#1153) This is a fix for issue 1124 - Segmentation fault when using specific names for tables. This issue is due to an oversight of some very specific types of tables that are parameterless functions. The logic to walk through these nodes didn't expect them and would crash due to them. This fix adds in code to skip over these types of tables. Added regression tests.
jrgemignani
added a commit
that referenced
this pull request
Aug 17, 2023
PR for moving the PG15 branch up to the current master branch. Contains all of the latest work in the master branch, which is currently at PostgreSQL version 15 at the time of this PR. When this PR is merged, PG15 will be the latest. Contains the following commits - * Added the toStringList() function (#1084) * Fix issue 1124: Segmentation fault when using specific tables (#1125) * Added the toStringList() function (#1128) * Fix issue 1000: Indexes created on WHERE (#1133)
MuhammadTahaNaveed
pushed a commit
to MuhammadTahaNaveed/age
that referenced
this pull request
Aug 24, 2023
…#1125) This is a fix for issue 1124 - Segmentation fault when using specific names for tables. This issue is due to an oversight of some very specific types of tables that are parameterless functions. The logic to walk through these nodes didn't expect them and would crash due to them. This fix adds in code to skip over these types of tables. Added regression tests.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a fix for issue 1124 -
Segmentation fault when using specific names for tables.
This issue is due to an oversight of some very specific types of tables that are parameterless functions. The logic to walk through these nodes didn't expect them and would crash due to them.
This fix adds in code to skip over these types of tables.
Added regression tests.