Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PR to merge master branch into PG15 branch #1158

Merged
merged 8 commits into from
Aug 17, 2023

Conversation

jrgemignani
Copy link
Contributor

PLEASE DO NOT MERGE until thoroughly reviewed. Additionally, this merge needs to be appropriately squashed before merging.

PR for moving the PG15 branch up to the current master branch prior to the release.

It contains all of the latest work in the master branch, which is currently at PostgreSQL version 15.

M4rcxs and others added 8 commits August 8, 2023 11:34
- This function is inspired by the "tostringlist" function in OpenCypher.https://neo4j.com/docs/cypher-manual/current/functions/list/#functions-tostringlist
- toStringList() converts a list of values and returns a list of string values. If any values are not convertible to string they will be null in the list returned.
- A list containing the converted elements; depending on the input value a converted value is either a string value or null.
- Also added the regression tests
…#1125)

This is a fix for issue 1124 -

Segmentation fault when using specific names for tables.

This issue is due to an oversight of some very specific types of
tables that are parameterless functions. The logic to walk through
these nodes didn't expect them and would crash due to them.

This fix adds in code to skip over these types of tables.

Added regression tests.
Fixed warning due to incorrect output type specifier and
unused variable.
This fixes the issue with applying indexes on the WHERE clause.

It does this by modifying the volatility flag for 3 functions -

    _agtype_build_vertex
    _agtype_build_edge
    _label_name

All three were verified to met the specifications for IMMUTABLE.
PR for moving the master branch up to PostgreSQL 15.

Contains all of the latest work in the master branch in addition to
all of the changes made to go from PostgreSQL version 14 to 15.

---------

Co-authored-by: John Gemignani <jrgemignani@gmail.com>
Co-authored-by: Muhammad Taha Naveed <m.taha.naveed27@gmail.com>
Co-authored-by: Shoaib <muhemmed.shoaib@gmail.com>
Co-authored-by: Panagiotis Foliadis <pfoliadis@hotmail.com>
Co-authored-by: Matheus Farias <matheusfarias519@gmail.com>
Co-authored-by: Mohamed Mokhtar <m.mokhtar@outlook.it>
Co-authored-by: Hannan Aamir <hannanaamir2000@gmail.com>
In this patch, all agtype_values, that are allocated while
processing the csv file, are free'd.
Conflicts:
	README.md
	src/backend/parser/cypher_expr.c
	src/backend/parser/cypher_gram.y
	src/backend/utils/adt/agtype.c
Copy link
Member

@rafsun42 rafsun42 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

Copy link
Member

@MuhammadTahaNaveed MuhammadTahaNaveed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

RELEASE Show resolved Hide resolved
Copy link
Member

@dehowef dehowef left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@jrgemignani jrgemignani merged commit 4765ee1 into apache:PG15 Aug 17, 2023
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PG15 PostgreSQL15
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants