treeview - deterministic and new getter #37162
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
raphaelauv
force-pushed
the
test/dag_tree_view
branch
from
84e4aa0
to
8521a10
Compare
dirrao
requested changes
Feb 4, 2024
|
Could you provide the example result in the description? Thanks! |
|
There is an example in the unit test |
potiuk
approved these changes
Feb 11, 2024
ephraimbuddy
pushed a commit
that referenced
this pull request
Feb 20, 2024
* treeview - determinist and new getter * review 1 --------- Co-authored-by: raphaelauv <raphaelauv@users.noreply.github.com> (cherry picked from commit 0c02ead)
ephraimbuddy
pushed a commit
that referenced
this pull request
Feb 22, 2024
* treeview - determinist and new getter * review 1 --------- Co-authored-by: raphaelauv <raphaelauv@users.noreply.github.com> (cherry picked from commit 0c02ead)
68 tasks
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
current treeview() only print a non deterministic ASCII representation of the dag
this new implementation is deterministic ( thanks to sort on task_id ) and add a getter to get the string representation