AIP-84: Migrating GET queued asset events for DAG to fastAPI #43934
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
boring-cyborg
bot
added
area:API
amoghrajesh
requested review from
bbovenzi,
pierrejeambrun,
ryanahamilton,
jscheffl and
ephraimbuddy
as code owners
amoghrajesh
added
the
legacy api
This was referenced Nov 13, 2024
amoghrajesh
requested review from
potiuk,
ashb,
jedcunningham,
mik-laj,
eladkal,
mobuchowski,
o-nikolas,
XD-DENG and
hussein-awala
as code owners
amoghrajesh
force-pushed
the
AIP84-get-all-queued-events-for-dag
branch
2 times, most recently
from
3af2873
to
2cd5dc1
Compare
|
@pierrejeambrun FYI, I have pushed the changes for all the "resolved" comments. The rest are open for input from you. EDIT: I kept the endpoint at public/dags.py cos if I move to assets, the path will become: |
This was referenced Nov 15, 2024
pierrejeambrun
approved these changes
Nov 15, 2024
amoghrajesh
commented
Nov 15, 2024
potiuk
added a commit
to potiuk/airflow
that referenced
this pull request
Nov 16, 2024
…pache#43934)" This reverts commit 3917730.
potiuk
added a commit
to potiuk/airflow
that referenced
this pull request
Nov 16, 2024
…pache#43934)" This reverts commit 3917730.
potiuk
added a commit
to potiuk/airflow
that referenced
this pull request
Nov 16, 2024
…pache#43934)" This reverts commit 3917730.
gopidesupavan
pushed a commit
that referenced
this pull request
Nov 16, 2024
kandharvishnu
pushed a commit
to kandharvishnu/airflow
that referenced
this pull request
Nov 19, 2024
…43934) * AIP-84: Migrating GET queued asset events for DAG to fastAPI * adding test cases * adding setup and teardown * review comments part 1 * introducing _generate_queued_event_where_clause * changing to bad request * adding paginated_select * moving _generate_queued_event_where_clause to assets.py * moving datamodels to assets * moving tests to assets * reuse fixtures from TestGetAssets and inherit classes to simplify * Move route to assets module * Small adjustments --------- Co-authored-by: pierrejeambrun <pierrejbrun@gmail.com>
kandharvishnu
pushed a commit
to kandharvishnu/airflow
that referenced
this pull request
Nov 19, 2024
…pache#43934)" (apache#44088) This reverts commit 3917730.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
related: #42370
Migrating the GET queued asset events for a DAG endpoint to fast API.
Setup:
Created producer and consumer dags:
Paused one producer while running the other to generate queued events
Responses:
Legacy
FastAPI
With time filtering:
(Beyond creation time)
(Beyond creation time)
Swagger spec: (maintained under dag section)
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in newsfragments.