Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: delete button in plugin drawer #1411

Closed
guoqqqi opened this issue Feb 1, 2021 · 13 comments · Fixed by #1597
Closed

test: delete button in plugin drawer #1411

guoqqqi opened this issue Feb 1, 2021 · 13 comments · Fixed by #1597
Assignees
Milestone

Comments

@guoqqqi
Copy link
Member

guoqqqi commented Feb 1, 2021

#1402
added a delete button to the drawer of the plugin in this PR,
now we need to add a test for it.

Related links on completing test development:
https://github.com/apache/apisix-dashboard/blob/a34317193cece2532ed333aaaacfd3a6af7328c4/docs/front-end-e2e.md

Very thanks!

@vinayaksh42
Copy link

can I work on this issue?

@imjoey
Copy link
Member

imjoey commented Feb 2, 2021

can I work on this issue?

@vinayaksh42 sure, thanks and looking forward to your pr.

@juzhiyuan
Copy link
Member

Hi, @vinayaksh42, once #1402 is merged, you could try to add testcase for it.

@vinayaksh42
Copy link

Hi, @vinayaksh42, once #1402 is merged, you could try to add testcase for it.

Sure

@guoqqqi
Copy link
Member Author

guoqqqi commented Feb 4, 2021

HI, @vinayaksh42 , #1402 has been merged, so you can start trying to add test cases to it.

@vinayaksh42
Copy link

HI, @vinayaksh42 , #1402 has been merged, so you can start trying to add test cases to it.

Thanks for the update, will get started with it

@juzhiyuan juzhiyuan added this to the 2.5 milestone Feb 7, 2021
@guoqqqi
Copy link
Member Author

guoqqqi commented Feb 20, 2021

Hi, any update? 😊

@vinayaksh42 vinayaksh42 removed their assignment Feb 23, 2021
@stu01509
Copy link
Contributor

Hi @guoqqqi

I'm interested in this issue, Could you assign this issue to me?

@nic-chen
Copy link
Member

@stu01509 thanks!

@guoqqqi
Copy link
Member Author

guoqqqi commented Feb 26, 2021

Hi @stu01509
Thank you very much and looking forward to your PR.

@nic-chen
Copy link
Member

ping @stu01509

@stu01509
Copy link
Contributor

Hi @nic-chen

Thanks for your mention, I will start to solve it.

@guoqqqi
Copy link
Member Author

guoqqqi commented Mar 15, 2021

ping @stu01509

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants