Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add delete button in plugin drawer #1402

Merged
merged 11 commits into from
Feb 4, 2021
Merged

feat: add delete button in plugin drawer #1402

merged 11 commits into from
Feb 4, 2021

Conversation

guoqqqi
Copy link
Member

@guoqqqi guoqqqi commented Jan 31, 2021

Please answer these questions before submitting a pull request


New feature or improvement

  • Describe the details and related test reports.
    Added delete plugin button

image

@guoqqqi
Copy link
Member Author

guoqqqi commented Jan 31, 2021

Still need to add a delete button method to achieve the function, I will update after~

@juzhiyuan juzhiyuan marked this pull request as draft January 31, 2021 11:55
@guoqqqi guoqqqi marked this pull request as ready for review February 1, 2021 12:48
@juzhiyuan
Copy link
Member

@guoqqqi LGTM, and please add test cases for this PR.

@codecov-io
Copy link

codecov-io commented Feb 2, 2021

Codecov Report

Merging #1402 (8067b80) into master (6e98820) will decrease coverage by 21.71%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##           master    #1402       +/-   ##
===========================================
- Coverage   66.90%   45.19%   -21.72%     
===========================================
  Files          44       35        -9     
  Lines        2937     2516      -421     
===========================================
- Hits         1965     1137      -828     
- Misses        732     1214      +482     
+ Partials      240      165       -75     
Impacted Files Coverage Δ
api/internal/filter/request_id.go 0.00% <0.00%> (-100.00%) ⬇️
api/internal/core/entity/entity.go 0.00% <0.00%> (-100.00%) ⬇️
api/internal/core/store/storehub.go 0.00% <0.00%> (-70.41%) ⬇️
api/internal/filter/cors.go 0.00% <0.00%> (-66.67%) ⬇️
api/internal/filter/schema.go 0.00% <0.00%> (-55.47%) ⬇️
api/internal/handler/upstream/upstream.go 28.81% <0.00%> (-54.24%) ⬇️
api/internal/utils/consts/api_error.go 0.00% <0.00%> (-50.00%) ⬇️
api/internal/handler/data_loader/route_import.go 27.41% <0.00%> (-37.50%) ⬇️
api/internal/handler/server_info/server_info.go 57.14% <0.00%> (-33.34%) ⬇️
api/internal/utils/closer.go 0.00% <0.00%> (-33.34%) ⬇️
... and 30 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6e98820...8067b80. Read the comment docs.

web/src/pages/Plugin/locales/en-US.ts Outdated Show resolved Hide resolved
web/src/pages/Plugin/locales/zh-CN.ts Outdated Show resolved Hide resolved
@juzhiyuan
Copy link
Member

@guoqqqi You need to merge the master branch into this one to fix Backend E2E failed.

@guoqqqi
Copy link
Member Author

guoqqqi commented Feb 2, 2021

@guoqqqi You need to merge the master branch into this one to fix Backend E2E failed.

I've updated the branch to the latest, but the CI didn't pass

@juzhiyuan
Copy link
Member

all right, wait for other PRs to fix this issue.

@juzhiyuan juzhiyuan merged commit dbfa426 into apache:master Feb 4, 2021
@juzhiyuan juzhiyuan deleted the plugin-button branch February 4, 2021 08:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

当Route中存在被禁用的插件时Service里的同名插件失效
4 participants