Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add limit-conn plugin form #1728

Merged
merged 10 commits into from
Apr 12, 2021
Merged

Conversation

LiteSun
Copy link
Member

@LiteSun LiteSun commented Apr 9, 2021

Please answer these questions before submitting a pull request, or your PR will get closed.

Why submit this pull request?

  • Bugfix
  • New feature provided
  • Improve performance
  • Backport patches

What changes will this PR take into?
Add limit-conn plugin form
image

Related issues

Checklist:

  • Did you explain what problem does this PR solve? Or what new features have been added?
  • Have you added corresponding test cases?
  • Have you modified the corresponding document?
  • Is this PR backward compatible? If it is not backward compatible, please discuss on the mailing list first

@codecov-io
Copy link

codecov-io commented Apr 9, 2021

Codecov Report

Merging #1728 (ce925d0) into master (990662a) will decrease coverage by 10.26%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##           master    #1728       +/-   ##
===========================================
- Coverage   62.55%   52.29%   -10.27%     
===========================================
  Files         123       38       -85     
  Lines        5253     2660     -2593     
  Branches      649        0      -649     
===========================================
- Hits         3286     1391     -1895     
+ Misses       1779     1081      -698     
  Partials      188      188               
Flag Coverage Δ
backend-unit-test 52.29% <ø> (ø)
frontend-e2e-test ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
web/src/pages/Service/components/Step1.tsx
web/src/pages/Upstream/transform.ts
...pages/Route/components/Step1/MatchingRulesView.tsx
web/src/helpers.tsx
web/src/pages/SSL/components/Step1/index.tsx
...rc/components/PluginOrchestration/customConfig.tsx
web/src/pages/User/Login.tsx
web/src/components/Upstream/constant.ts
...pages/SSL/components/CertificateUploader/index.tsx
web/src/pages/Upstream/components/Step1.tsx
... and 74 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 990662a...ce925d0. Read the comment docs.

web/src/components/Plugin/UI/limit-conn.tsx Outdated Show resolved Hide resolved
web/src/components/Plugin/UI/limit-conn.tsx Outdated Show resolved Hide resolved
web/src/components/Plugin/UI/limit-conn.tsx Outdated Show resolved Hide resolved
web/src/components/Plugin/UI/limit-conn.tsx Outdated Show resolved Hide resolved
web/src/components/Plugin/UI/limit-conn.tsx Outdated Show resolved Hide resolved
@nic-chen nic-chen requested review from imjoey and liuxiran April 12, 2021 06:24
@netlify
Copy link

netlify bot commented Apr 12, 2021

Deploy preview for apisix-dashboard ready!

Built with commit 9afc7f5

https://deploy-preview-1728--apisix-dashboard.netlify.app

@LiteSun LiteSun merged commit c68e2d2 into apache:master Apr 12, 2021
@LiteSun LiteSun deleted the limit-conn-plugin-form branch April 12, 2021 12:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants