feat: add publish status to route in manager api #450

liuxiran · 2020-09-07T14:30:04Z

Please answer these questions before submitting a pull request

Why submit this pull request?
Bug fix
New feature provided
Improve performance
Related issues
issue Feature：route publish management #437 manage api

Bugfix

Description
How to fix?

New feature or improvement

Describe the details and related test reports.

add a Column to route, called status
status = true, means create a new route in both mysql and apisix; status=false: means create a route only in mysql
modified the logic of editing and deleting route at the same time,
add manager apis to support change route status

moonming · 2020-09-08T04:00:45Z

nice work @liuxiran 👍
it will be better if you can add some test cases.

api/route/route.go

juzhiyuan

Looks good to me from those logics, but still need a review from @nic-chen @gxthrj

juzhiyuan · 2020-09-09T09:05:12Z

@liuxiran CI failed, please take a look

liuxiran · 2020-09-09T09:07:30Z

@liuxiran CI failed, please take a look

fixing :)

liuxiran · 2020-09-09T10:13:34Z

the reason for ci failed is the same with #452 (comment) , we updated the logic of routeGroup. this pr is depend on pr #460

@juzhiyuan so sorry for the interdependence between these prs. I'll pay attention next time~!

juzhiyuan · 2020-09-09T10:17:47Z

@liuxiran ok, so just waiting for others' review :DD

liuxiran · 2020-09-09T10:37:19Z

@liuxiran ok, so just waiting for others' review :DD

thanks for your time~

api/route/route.go

api/route/route_test.go

api/script/db/schema.sql

nic-chen · 2020-09-10T00:56:00Z

api ci not pass

juzhiyuan · 2020-09-10T01:55:36Z

the reason for ci failed is the same with #452 (comment) , we updated the logic of routeGroup. this pr is depend on pr #460

@juzhiyuan so sorry for the interdependence between these prs. I'll pay attention next time~!

@nic-chen maybe this reason?

nic-chen · 2020-09-10T04:56:04Z

the reason for ci failed is the same with #452 (comment) , we updated the logic of routeGroup. this pr is depend on pr #460

@juzhiyuan so sorry for the interdependence between these prs. I'll pay attention next time~!

@nic-chen maybe this reason?

maybe.so we should handle that pr first.

juzhiyuan · 2020-09-12T11:02:46Z

@nic-chen #460 has been merged, please take a look.

nic-chen · 2020-09-14T16:15:50Z

api/route/route_test.go

      "paths":["/*"],
      "methods":["GET","HEAD","POST","PUT","DELETE","OPTIONS","PATCH"],
-      "status":false,
+      "status":true,


why is true for offline ?

'offline' is a PUT type API, so create a route online first, then we could do offline :)

* feat: add publish status to route in manager api * fix: update publish and offline route * feat: add route publish test module * fix: synchronize content for route publish/offline

* feat: preview pluginchart (#456) * feat: added pluginchart preview in route step4 * feat: change PluginChart to PluginOrchestration * add tools to check ASF headers in code files. (#454) * chore: remove unnecessary license file (#462) * remove unnecessary license file * remove unnecessary license file for `api7 dashboard` * Increase the checking of .conf and .toml files. And delete the redundant configuration of the ASF-Release.cfg file. (#461) * Increase the checking of .conf and .toml files. * Skip the check of dag-to-lua-1.1/README.md file * Put the "run Makefile" check before "get lua lib". * Put the "run Makefile" check before "get lua lib". * Put the "run Makefile" check before "get lua lib". Co-authored-by: lin <lin@MBPro.local> * ci: Add lint (#455) Co-authored-by: Rapiz <code@rapiz.me> * Feat: dashboard support route group (#433) * feat: route group UI * feat(route-ui): add routegroup when create route * fix: add routegroup to route list * fix: support add routegroup together with route * fix: route path define error * feat: trigger redeploy * fix: update i18n key Co-authored-by: 琚致远 <juzhiyuan@apache.org> * feature:Independent license check operation file. (#465) * feat: support ungroup in manager api (#460) * feat: support ungroup in manager api * fix: synchronize route group to route * fix: update test case * feat: add publish status to route in manager api (#450) * feat: add publish status to route in manager api * fix: update publish and offline route * feat: add route publish test module * fix: synchronize content for route publish/offline * feat(route): add publish and offline to route (#451) * feat(route): add publish and offline to route * feat: trigger redeploy * feat: trigger redeploy * Update Create.tsx * fix: update refer to the code review * fix: init status default value * fix: add a help msg to status Form.Item Co-authored-by: 琚致远 <juzhiyuan@apache.org> * feat: remove netlify (#472) * fix: host should not be required (#477) * feat: added new plugin dependency (#475) * feat: added new plugin dependency * feat: omit shadow var * feat: omit shadow var * fix: host should not be required (#479) * fix: host should not be required * feat: remove required rule * feat: Route debug (#485) * feat: new api get route and apisix url * feat: online debug * fix: update refer to the review, fix logical error as well * fix: rename getRouteWithApisixUrl * feat: update plugin (#482) * feat: improve route (#483) * feat: improve step1 * feat: improve step2 * feat: improve createStep4 * feat: improve transform * fix: event loop * feat: clean code * fix: lost route_group info when enable redirect * feat: UI improve * fix: checkHostWithSSL with empty hosts * Update Create.tsx Co-authored-by: Firstsawyou <52862365+Firstsawyou@users.noreply.github.com> Co-authored-by: nic-chen <33000667+nic-chen@users.noreply.github.com> Co-authored-by: lin <lin@MBPro.local> Co-authored-by: Rapiz <contact@rapiz.me> Co-authored-by: Rapiz <code@rapiz.me> Co-authored-by: liuxiran <belovedxixi@126.com> Co-authored-by: 琚致远 <juzhiyuan@apache.org>

liuxiran mentioned this pull request Sep 7, 2020

feat(route): add publish and offline to route #451

Merged

3 tasks

liuxiran force-pushed the route_publish_api branch from b747828 to ae2a1b1 Compare September 7, 2020 15:10

juzhiyuan requested review from gxthrj and nic-chen September 7, 2020 17:09

bzp2010 mentioned this pull request Sep 8, 2020

Feature：route publish management #437

Closed

5 tasks

juzhiyuan reviewed Sep 9, 2020

View reviewed changes

api/route/route.go Show resolved Hide resolved

juzhiyuan approved these changes Sep 9, 2020

View reviewed changes

liuxiran force-pushed the route_publish_api branch from 9352b53 to 5e2c54a Compare September 9, 2020 08:35

juzhiyuan requested a review from bzp2010 September 9, 2020 09:22

liuxiran mentioned this pull request Sep 9, 2020

feat: support ungroup in manager api #460

Merged

3 tasks

nic-chen requested changes Sep 10, 2020

View reviewed changes

api/route/route.go Show resolved Hide resolved

api/route/route_test.go Show resolved Hide resolved

api/script/db/schema.sql Show resolved Hide resolved

liuxiran force-pushed the route_publish_api branch from 5d7e3a1 to 3a80623 Compare September 10, 2020 15:52

liuxiran added 4 commits September 11, 2020 11:28

feat: add publish status to route in manager api

52af2c1

fix: update publish and offline route

a60b76b

feat: add route publish test module

e041df2

fix: synchronize content for route publish/offline

78324a1

liuxiran force-pushed the route_publish_api branch from 3a80623 to 78324a1 Compare September 11, 2020 05:55

nic-chen reviewed Sep 14, 2020

View reviewed changes

nic-chen approved these changes Sep 15, 2020

View reviewed changes

juzhiyuan merged commit 09c5be9 into apache:master Sep 15, 2020

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: add publish status to route in manager api #450

feat: add publish status to route in manager api #450

liuxiran commented Sep 7, 2020

moonming commented Sep 8, 2020

juzhiyuan left a comment

juzhiyuan commented Sep 9, 2020

liuxiran commented Sep 9, 2020

liuxiran commented Sep 9, 2020

juzhiyuan commented Sep 9, 2020

liuxiran commented Sep 9, 2020

nic-chen commented Sep 10, 2020

juzhiyuan commented Sep 10, 2020

nic-chen commented Sep 10, 2020

juzhiyuan commented Sep 12, 2020

nic-chen Sep 14, 2020

liuxiran Sep 14, 2020 •

edited

Loading

feat: add publish status to route in manager api #450

feat: add publish status to route in manager api #450

Conversation

liuxiran commented Sep 7, 2020

Bugfix

New feature or improvement

moonming commented Sep 8, 2020

juzhiyuan left a comment

Choose a reason for hiding this comment

juzhiyuan commented Sep 9, 2020

liuxiran commented Sep 9, 2020

liuxiran commented Sep 9, 2020

juzhiyuan commented Sep 9, 2020

liuxiran commented Sep 9, 2020

nic-chen commented Sep 10, 2020

juzhiyuan commented Sep 10, 2020

nic-chen commented Sep 10, 2020

juzhiyuan commented Sep 12, 2020

nic-chen Sep 14, 2020

Choose a reason for hiding this comment

liuxiran Sep 14, 2020 • edited Loading

Choose a reason for hiding this comment

liuxiran Sep 14, 2020 •

edited

Loading