add tools to check ASF headers in code files. #454

Firstsawyou · 2020-09-08T04:49:36Z

Please answer these questions before submitting a pull request

Why submit this pull request?
Bug fix
New feature provided
Improve performance
Related issues

Bugfix

Description
How to fix?

New feature or improvement

Describe the details and related test reports.
add tools to check ASF headers in code files.

moonming · 2020-09-08T04:52:57Z

.github/workflows/api_ci.yml

+
+    - name: run Makefile
+      run: |
+        sudo make license-check


why add sudo?

Add too much, I need to delete.

moonming · 2020-09-08T04:53:13Z

.travis.yml

@@ -0,0 +1,49 @@
+dist: bionic


we using github actions, not travis as CI

Ok, I will modify.

moonming · 2020-09-08T04:53:43Z

.travis/ASF-Release.cfg

+.travis/openwhisk-utilities
+
+# Exclude dashboard files
+dashboard


this repo not has dashborad dir

moonming · 2020-09-08T04:54:02Z

.travis/ASF-Release.cfg

+build-cache
+deps
+test-nginx
+grpc_server_example
+.travis.yml
+grpcurl
+t/servroot
+


we don't have those dirs

Ok, I know.

.travis/ASF-Release.cfg

Makefile

… the ".travis" file name to ".actions"

juzhiyuan · 2020-09-08T12:04:20Z

@Firstsawyou This PR is only for the manager-api? or work both for Dashboard and manager API?

Firstsawyou

@Firstsawyou This PR is only for the manager-api? or work both for Dashboard and manager API?
work both for Dashboard and manager API.

Firstsawyou · 2020-09-08T05:02:19Z

.github/workflows/api_ci.yml

+
+    - name: run Makefile
+      run: |
+        sudo make license-check


Add too much, I need to delete.

Firstsawyou · 2020-09-08T05:05:03Z

.travis.yml

@@ -0,0 +1,49 @@
+dist: bionic


Ok, I will modify.

Firstsawyou · 2020-09-08T07:36:29Z

.travis/ASF-Release.cfg

+build-cache
+deps
+test-nginx
+grpc_server_example
+.travis.yml
+grpcurl
+t/servroot
+


Ok, I know.

Firstsawyou · 2020-09-08T07:36:57Z

.travis/ASF-Release.cfg

+.travis/openwhisk-utilities
+
+# Exclude dashboard files
+dashboard


moonming · 2020-09-08T12:29:00Z

.actions/ASF-Release.cfg

+*.yaml=has_block_license,  eol_at_eof, regex_check
+*.yml=has_block_license,  eol_at_eof, regex_check
+*.css=has_block_license, regex_check
+*Dockerfile*=has_block_license


we need add rule for .tsx files.

moonming · 2020-09-08T12:31:52Z

@Firstsawyou please check the output of CI: https://github.com/apache/apisix-dashboard/pull/454/checks?check_run_id=1085838821
you need to fix all error messages.

Firstsawyou · 2020-09-08T12:52:36Z

@Firstsawyou please check the output of CI: https://github.com/apache/apisix-dashboard/pull/454/checks?check_run_id=1085838821
you need to fix all error messages.
okay.

* feat: preview pluginchart (#456) * feat: added pluginchart preview in route step4 * feat: change PluginChart to PluginOrchestration * add tools to check ASF headers in code files. (#454) * chore: remove unnecessary license file (#462) * remove unnecessary license file * remove unnecessary license file for `api7 dashboard` * Increase the checking of .conf and .toml files. And delete the redundant configuration of the ASF-Release.cfg file. (#461) * Increase the checking of .conf and .toml files. * Skip the check of dag-to-lua-1.1/README.md file * Put the "run Makefile" check before "get lua lib". * Put the "run Makefile" check before "get lua lib". * Put the "run Makefile" check before "get lua lib". Co-authored-by: lin <lin@MBPro.local> * ci: Add lint (#455) Co-authored-by: Rapiz <code@rapiz.me> * Feat: dashboard support route group (#433) * feat: route group UI * feat(route-ui): add routegroup when create route * fix: add routegroup to route list * fix: support add routegroup together with route * fix: route path define error * feat: trigger redeploy * fix: update i18n key Co-authored-by: 琚致远 <juzhiyuan@apache.org> * feature:Independent license check operation file. (#465) * feat: support ungroup in manager api (#460) * feat: support ungroup in manager api * fix: synchronize route group to route * fix: update test case * feat: add publish status to route in manager api (#450) * feat: add publish status to route in manager api * fix: update publish and offline route * feat: add route publish test module * fix: synchronize content for route publish/offline * feat(route): add publish and offline to route (#451) * feat(route): add publish and offline to route * feat: trigger redeploy * feat: trigger redeploy * Update Create.tsx * fix: update refer to the code review * fix: init status default value * fix: add a help msg to status Form.Item Co-authored-by: 琚致远 <juzhiyuan@apache.org> * feat: remove netlify (#472) * fix: host should not be required (#477) * feat: added new plugin dependency (#475) * feat: added new plugin dependency * feat: omit shadow var * feat: omit shadow var * fix: host should not be required (#479) * fix: host should not be required * feat: remove required rule * feat: Route debug (#485) * feat: new api get route and apisix url * feat: online debug * fix: update refer to the review, fix logical error as well * fix: rename getRouteWithApisixUrl * feat: update plugin (#482) * feat: improve route (#483) * feat: improve step1 * feat: improve step2 * feat: improve createStep4 * feat: improve transform * fix: event loop * feat: clean code * fix: lost route_group info when enable redirect * feat: UI improve * fix: checkHostWithSSL with empty hosts * Update Create.tsx Co-authored-by: Firstsawyou <52862365+Firstsawyou@users.noreply.github.com> Co-authored-by: nic-chen <33000667+nic-chen@users.noreply.github.com> Co-authored-by: lin <lin@MBPro.local> Co-authored-by: Rapiz <contact@rapiz.me> Co-authored-by: Rapiz <code@rapiz.me> Co-authored-by: liuxiran <belovedxixi@126.com> Co-authored-by: 琚致远 <juzhiyuan@apache.org>

Firstsawyou added 3 commits September 8, 2020 11:57

add tools to check ASF headers in code files

0bcfab3

add tools to check ASF headers in code files

9107b1c

add tools to check ASF headers in code files

5b2290e

moonming requested changes Sep 8, 2020

View reviewed changes

moonming reviewed Sep 8, 2020

View reviewed changes

.travis/ASF-Release.cfg Outdated Show resolved Hide resolved

Makefile Outdated Show resolved Hide resolved

Firstsawyou added 2 commits September 8, 2020 19:11

Delete the useless configuration of "ASF-Release.cfg" file and rename…

769c870

… the ".travis" file name to ".actions"

Delete the useless configuration of "ASF-Release.cfg" file and rename…

5aa3de2

… the ".travis" file name to ".actions"

Firstsawyou force-pushed the my_branch branch from 9533301 to 5aa3de2 Compare September 8, 2020 12:01

Firstsawyou commented Sep 8, 2020

View reviewed changes

moonming requested changes Sep 8, 2020

View reviewed changes

Firstsawyou force-pushed the my_branch branch from 8110d4a to 5aa3de2 Compare September 9, 2020 06:47

Firstsawyou added 4 commits September 9, 2020 15:15

add check ASF headers rule for .tsx,.ts and .less files

9983132

Fix the error message of "make license-check".

dabaae0

Fix the error message of "make license-check".

f71b9a3

Fix the error message of "make license-check".

dc42c7a

moonming approved these changes Sep 9, 2020

View reviewed changes

nic-chen approved these changes Sep 9, 2020

View reviewed changes

moonming merged commit 54f7a98 into apache:master Sep 9, 2020

LiteSun pushed a commit to LiteSun/incubator-apisix-dashboard that referenced this pull request Sep 21, 2020

add tools to check ASF headers in code files. (apache#454)

8ff2080

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

add tools to check ASF headers in code files. #454

add tools to check ASF headers in code files. #454

Firstsawyou commented Sep 8, 2020 •

edited by moonming

Loading

moonming Sep 8, 2020

Firstsawyou Sep 8, 2020

moonming Sep 8, 2020

Firstsawyou Sep 8, 2020

moonming Sep 8, 2020

Firstsawyou Sep 8, 2020

moonming Sep 8, 2020

Firstsawyou Sep 8, 2020

juzhiyuan commented Sep 8, 2020

Firstsawyou left a comment

Firstsawyou Sep 8, 2020

Firstsawyou Sep 8, 2020

Firstsawyou Sep 8, 2020

Firstsawyou Sep 8, 2020

moonming Sep 8, 2020

Firstsawyou Sep 8, 2020

moonming commented Sep 8, 2020 •

edited

Loading

Firstsawyou commented Sep 8, 2020

add tools to check ASF headers in code files. #454

add tools to check ASF headers in code files. #454

Conversation

Firstsawyou commented Sep 8, 2020 • edited by moonming Loading

Bugfix

New feature or improvement

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

juzhiyuan commented Sep 8, 2020

Firstsawyou left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

moonming commented Sep 8, 2020 • edited Loading

Firstsawyou commented Sep 8, 2020

Firstsawyou commented Sep 8, 2020 •

edited by moonming

Loading

moonming commented Sep 8, 2020 •

edited

Loading