test: e2e test chash upstream with key (query_string, arg_xxx) #932
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #932 +/- ##
==========================================
- Coverage 43.10% 43.02% -0.08%
==========================================
Files 18 18
Lines 1290 1290
==========================================
- Hits 556 555 -1
- Misses 642 643 +1
Partials 92 92
Continue to review full report at Codecov.
|
3 tasks
idbeta
changed the title
membphis
reviewed
Dec 2, 2020
| } | ||
| resp.Body.Close() | ||
| } | ||
| //the results will be distributed among the 3 upstream |
There was a problem hiding this comment.
please add a comment: todo: need to find a better way to confirm the result
| testCaseCheck(tc) | ||
| } | ||
|
|
||
| //hit routes |
There was a problem hiding this comment.
bad comment style, please fix other similar points
Comment on lines
132
to
144
| { | ||
| caseDesc: "create route using the upstream just created", | ||
| Object: ManagerApiExpect(t), | ||
| Method: http.MethodPut, | ||
| Path: "/apisix/admin/routes/1", | ||
| Body: `{ | ||
| "uri": "/server_port", | ||
| "upstream_id": "1" | ||
| }`, | ||
| Headers: map[string]string{"Authorization": token}, | ||
| ExpectStatus: http.StatusOK, | ||
| Sleep: sleepTime, | ||
| }, |
There was a problem hiding this comment.
membphis
approved these changes
Dec 2, 2020
| counts = append(counts, value) | ||
| } | ||
| sort.Ints(counts) | ||
| assert.True(t, float64(counts[2]-counts[0]) / float64(counts[1]) < 0.4) // the result is unstable, fix it later |
| counts = append(counts, value) | ||
| } | ||
| sort.Ints(counts) | ||
| assert.True(t, float64(counts[2]-counts[0]) / float64(counts[1]) < 0.4) // the result is unstable, fix it later |
|
ping @idbeta |
nic-chen
approved these changes
Dec 2, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please answer these questions before submitting a pull request
related issue: #908