Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug: grpc-transcode do not close core.config instance when the plugin is unloaded #8519

Closed
kingluo opened this issue Dec 14, 2022 · 0 comments · Fixed by #8557
Closed

bug: grpc-transcode do not close core.config instance when the plugin is unloaded #8519

kingluo opened this issue Dec 14, 2022 · 0 comments · Fixed by #8557

Comments

@kingluo
Copy link
Contributor

kingluo commented Dec 14, 2022

Current Behavior

protos, err = core.config.new("/protos", {
automatic = true,
item_schema = core.schema.proto
})

This plugin does not define destroy().

config instance of etcd would create a timer to refresh "/protos" resource. We need to close the instance in destroy(), which in turn closes the timer.

Expected Behavior

No response

Error Logs

No response

Steps to Reproduce

curl http://127.0.0.1:9180/apisix/admin/plugins/reload -H 'X-API-KEY: edd1c9f034335f136f87ad84b625c8f1' -X PUT

Environment

  • APISIX version (run apisix version): master branch
  • Operating system (run uname -a):
  • OpenResty / Nginx version (run openresty -V or nginx -V):
  • etcd version, if relevant (run curl http://127.0.0.1:9090/v1/server_info):
  • APISIX Dashboard version, if relevant:
  • Plugin runner version, for issues related to plugin runners:
  • LuaRocks version, for installation issues (run luarocks --version):
spacewander pushed a commit that referenced this issue Dec 27, 2022
spacewander pushed a commit to spacewander/incubator-apisix that referenced this issue Jan 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant