fix: define destroy() to close protos #8557
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spacewander
reviewed
Dec 23, 2022
| @@ -270,5 +270,10 @@ function _M.init() | |||
| end | |||
| end | |||
|
|
|||
| function _M.destroy() | |||
| if protos then | |||
| protos:close() | |||
There was a problem hiding this comment.
Could we add a test to ensure the close is called? For instance, via injecting some code.
spacewander
reviewed
Dec 26, 2022
| end | ||
| } | ||
| } | ||
| --- timeout: 3 |
There was a problem hiding this comment.
The default timeout is already 3 seconds. We don't need to repeat it.
spacewander
approved these changes
Dec 27, 2022
soulbird
approved these changes
Dec 27, 2022
spacewander
pushed a commit
to spacewander/incubator-apisix
that referenced
this pull request
Jan 28, 2023
spacewander
pushed a commit
that referenced
this pull request
Jan 30, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes #8519
Checklist