-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: update CN and EN how-to-build document #4577
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Yiyiyimu
approved these changes
Jul 9, 2021
juzhiyuan
reviewed
Jul 12, 2021
yzeng25
force-pushed
the
0708_01
branch
2 times, most recently
from
July 12, 2021 04:46
2e216b8
to
6be2875
Compare
👍 |
tao12345666333
requested changes
Jul 13, 2021
tao12345666333
approved these changes
Jul 13, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approved.
left one comment.
I will convert it back once EN document is ready. Thanks guys! |
yzeng25
changed the title
docs: update CN how-to-build document
docs: update CN and EN how-to-build document
Jul 13, 2021
PR is ready for re-review. |
juzhiyuan
approved these changes
Jul 14, 2021
This was referenced Jul 26, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
This PR provides updates on the 'how-to-build' document in Chinese and English:
make quit
andmake stop
, and suggested to usemake quit
rather thanmake stop
.$
sign in the beginning of each code block, changes of '```shell' in the beginning of each code block.TODO:
Update CN how-to-build document based on review comments.(Done)Update EN how-to-build document based CN how-to-build document.(Done)Update EN how-to-build document based on review comments again.(Done)Pre-submission checklist: