Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: fix section titles' links #4671

Merged
merged 1 commit into from
Jul 26, 2021

Conversation

yzeng25
Copy link
Contributor

@yzeng25 yzeng25 commented Jul 26, 2021

What this PR does / why we need it:

Backport #4669 to release v2.8.

PR #4577 and #4546 modified sections' titles in 'Getting Started' and 'How to build Apache APISIX' docs in EN and ZH. But the links from other files linked to some titles in these 2 docs were not modified accordingly. Thus, it creates broken links. For example, how-to-build.md#6-build-openresty-for-apisix should be how-to-build.md#step-6-build-openresty-for-apache-apisix instead.

After checking, PR #4546 did not introduce broken links, PR #4577 introduced a lot of (10+) broken links. They were not technically 'broken broken', they can redirect to correct pages, but they cannot redirect to the right spot in these pages.

This PR fixed broken links from PR #4577.

Pre-submission checklist:

  • Did you explain what problem does this PR solve? Or what new features have been added?
  • Have you added corresponding test cases?
  • Have you modified the corresponding document?
  • Is this PR backward compatible? If it is not backward compatible, please discuss on the mailing list first

@yzeng25 yzeng25 marked this pull request as ready for review July 26, 2021 03:36
@spacewander spacewander merged commit 69e54d4 into apache:release/2.8 Jul 26, 2021
spacewander added a commit that referenced this pull request Jul 27, 2021
* feat: release 2.8

Signed-off-by: spacewander <spacewanderlzx@gmail.com>

* docs: fix section titles' links (#4671)

Co-authored-by: yilinzeng <36651058+yzeng25@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants