Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: duplicate X-Forwarded-Proto will be sent as string #7229

Merged
merged 5 commits into from
Jun 13, 2022

Conversation

soulbird
Copy link
Contributor

@soulbird soulbird commented Jun 10, 2022

Description

duplicate request header: X-Forwarded-Proto will be sent as string instread of table address

Fixes #7215

Checklist

  • I have explained the need for this PR and the problem it solves
  • I have explained the changes or the new features added to this PR
  • I have added tests corresponding to this change
  • I have updated the documentation to reflect this change
  • I have verified that this change is backward compatible (If not, please discuss on the APISIX mailing list first)

@soulbird soulbird marked this pull request as ready for review June 13, 2022 01:36
apisix/init.lua Outdated Show resolved Hide resolved
t/node/x-forwarded.t Outdated Show resolved Hide resolved
t/node/x-forwarded.t Outdated Show resolved Hide resolved
@spacewander spacewander merged commit eb62ac0 into apache:master Jun 13, 2022
@nic-chen
Copy link
Member

hi @soulbird
could you please backport the change to 2.13 and 2.10 too? thank you very much!

hongbinhsu pushed a commit to fitphp/apix that referenced this pull request Jun 16, 2022
* upstream/master: (46 commits)
  docs: fix err in batch-processor (apache#7259)
  docs(deployment): sync design to online docs (apache#7256)
  feat(deployment): add structure of traditional role (apache#7249)
  fix(benchmark): write worker_processes into config.yaml (apache#7250)
  docs: correct the repo url (apache#7253)
  feat: Add support for capturing OIDC refresh tokens (apache#7220)
  feat(ssl): support get upstream cert from ssl object (apache#7221)
  chore: validate etcd conf strictly (apache#7245)
  fix(api-response): check response header format (apache#7238)
  fix: duplicate X-Forwarded-Proto will be sent as string (apache#7229)
  fix: distinguish different upstreams even they have the same addr (apache#7213)
  docs: make company on README more preciser (apache#7230)
  test: remove unused required etcd (apache#7225)
  fix: add debug yaml validation (apache#7201)
  change: remove upstream.enable_websocket which is deprecated since 2020 (apache#7222)
  docs: add re case on response-rewrite plugin (apache#7197)
  docs: add API Gateway keyword and AWS graviton3. (apache#7217)
  fix(response-rewrite): schema format error (apache#7212)
  docs(proxy-rewrite): remove empty space (apache#7210)
  chore: require http_stub_status_module exists (apache#7208)
  ...
soulbird added a commit to soulbird/apisix that referenced this pull request Jun 24, 2022
Co-authored-by: soulbird <zhaothree@gmail.com>
nic-chen pushed a commit to nic-chen/apisix that referenced this pull request Jun 25, 2022
Co-authored-by: soulbird <zhaothree@gmail.com>
nic-chen pushed a commit to nic-chen/apisix that referenced this pull request Jun 25, 2022
Co-authored-by: soulbird <zhaothree@gmail.com>
spacewander pushed a commit that referenced this pull request Jun 26, 2022
* fix: duplicate X-Forwarded-Proto will be sent as string (#7229)

Co-authored-by: soulbird <zhaothree@gmail.com>

* perf: don't cache all request headers on critical code path (#7287)

Co-authored-by: soulbird <zhaothree@gmail.com>
spacewander pushed a commit that referenced this pull request Jun 27, 2022
…ream as string (#7326)

* fix: duplicate X-Forwarded-Proto will be sent as string (#7229)

Co-authored-by: soulbird <zhaothree@gmail.com>

* perf: don't cache all request headers on critical code path (#7287)

Co-authored-by: soulbird <zhaoshir@outlook.com>
Co-authored-by: soulbird <zhaothree@gmail.com>
spacewander pushed a commit that referenced this pull request Jun 30, 2022
Co-authored-by: soulbird <zhaothree@gmail.com>
Liu-Junlin pushed a commit to Liu-Junlin/apisix that referenced this pull request Nov 4, 2022
Co-authored-by: soulbird <zhaothree@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bug: X-Forwarded-Proto header should not be set for upstream as a table
5 participants