Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(deployment): sync design to online docs #7256

Merged
merged 4 commits into from
Jun 16, 2022

Conversation

spacewander
Copy link
Member

Signed-off-by: spacewander spacewanderlzx@gmail.com

Description

Fixes # (issue)

Checklist

  • I have explained the need for this PR and the problem it solves
  • I have explained the changes or the new features added to this PR
  • I have added tests corresponding to this change
  • I have updated the documentation to reflect this change
  • I have verified that this change is backward compatible (If not, please discuss on the APISIX mailing list first)

Signed-off-by: spacewander <spacewanderlzx@gmail.com>
@spacewander spacewander marked this pull request as ready for review June 15, 2022 09:35
Co-authored-by: Sylvia <39793568+SylviaBABY@users.noreply.github.com>

### Traditional

![traditional](../../../assets/images/deployment-traditional.svg)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please do not use a transparent background as the base color of the image.The picture will not be clear when enlarged.
image

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't have the non-transparent version of the image. If there is not a simple way to add background, what about removing them?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have edited those with white background, you can use that.

11

22

Thanks for @SylviaBABY

Signed-off-by: spacewander <spacewanderlzx@gmail.com>
Signed-off-by: spacewander <spacewanderlzx@gmail.com>
@spacewander spacewander merged commit d57ac67 into apache:master Jun 16, 2022
hongbinhsu pushed a commit to fitphp/apix that referenced this pull request Jun 16, 2022
* upstream/master: (46 commits)
  docs: fix err in batch-processor (apache#7259)
  docs(deployment): sync design to online docs (apache#7256)
  feat(deployment): add structure of traditional role (apache#7249)
  fix(benchmark): write worker_processes into config.yaml (apache#7250)
  docs: correct the repo url (apache#7253)
  feat: Add support for capturing OIDC refresh tokens (apache#7220)
  feat(ssl): support get upstream cert from ssl object (apache#7221)
  chore: validate etcd conf strictly (apache#7245)
  fix(api-response): check response header format (apache#7238)
  fix: duplicate X-Forwarded-Proto will be sent as string (apache#7229)
  fix: distinguish different upstreams even they have the same addr (apache#7213)
  docs: make company on README more preciser (apache#7230)
  test: remove unused required etcd (apache#7225)
  fix: add debug yaml validation (apache#7201)
  change: remove upstream.enable_websocket which is deprecated since 2020 (apache#7222)
  docs: add re case on response-rewrite plugin (apache#7197)
  docs: add API Gateway keyword and AWS graviton3. (apache#7217)
  fix(response-rewrite): schema format error (apache#7212)
  docs(proxy-rewrite): remove empty space (apache#7210)
  chore: require http_stub_status_module exists (apache#7208)
  ...
spacewander added a commit that referenced this pull request Jun 30, 2022
* docs(deployment): sync design to online docs

Signed-off-by: spacewander <spacewanderlzx@gmail.com>

* Apply suggestions from code review

Co-authored-by: Sylvia <39793568+SylviaBABY@users.noreply.github.com>

* change image

Thanks for @SylviaBABY

Signed-off-by: spacewander <spacewanderlzx@gmail.com>

* change

Signed-off-by: spacewander <spacewanderlzx@gmail.com>

Co-authored-by: Sylvia <39793568+SylviaBABY@users.noreply.github.com>
Liu-Junlin pushed a commit to Liu-Junlin/apisix that referenced this pull request Nov 4, 2022
* docs(deployment): sync design to online docs

Signed-off-by: spacewander <spacewanderlzx@gmail.com>

* Apply suggestions from code review

Co-authored-by: Sylvia <39793568+SylviaBABY@users.noreply.github.com>

* change image

Thanks for @SylviaBABY

Signed-off-by: spacewander <spacewanderlzx@gmail.com>

* change

Signed-off-by: spacewander <spacewanderlzx@gmail.com>

Co-authored-by: Sylvia <39793568+SylviaBABY@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants