feat: add dafault value roundrobin for upstream_schema #8180
Conversation
|
we need to update test cases and docs |
ok i will do it |
| "nodes": { | ||
| "127.0.0.1:8080": 1 | ||
| } | ||
| }]] |
There was a problem hiding this comment.
Better to check the default value of type like
Line 46 in 48b8431
|
Do we need to remove a lot of |
t/admin/upstream.t
Outdated
| ngx.say(body) | ||
|
|
||
| local res = assert(etcd.get('/upstreams/admin_up')) | ||
| local create_time = res.body.node.value.create_time |
There was a problem hiding this comment.
We don't need to check xxx_time, right?
There was a problem hiding this comment.
Right, I have fixed it.
Yes, let's do it with script. |
| @@ -437,6 +437,7 @@ local upstream_schema = { | |||
| type = { | |||
| description = "algorithms of load balancing", | |||
| type = "string", | |||
| default = "roundrobin", | |||
There was a problem hiding this comment.
Do we need to update the doc too?
There was a problem hiding this comment.
I have done. pls see description. @spacewander @tokers
There was a problem hiding this comment.
Could you please put the doc in the same PR next time?
So people don't need to check another one.
* upstream/master: (94 commits) test: add test cases for ai module (apache#8222) fix(ai): typo key name (apache#8232) docs: update the docs of admin API (apache#8191) Update standalone docs for change in SSL parameter (apache#8242) fix: can not modify x-forwarded-host in proxy rewrite (apache#8200) chore: export the set cert/key process so we can hook it (apache#8228) test: add cases of ai module (apache#8214) feat: add dafault value roundrobin for upstream_schema (apache#8180) docs: update limit plugin docs (apache#8154) dix remote_addr (apache#8210) fix(zipkin): send trace IDs with a reject sampling decision (apache#8099) docs: update hmac-auth doc (apache#8192) docs: update limit count plugin doc (apache#8196) docs: fix building apisix misled (apache#8189) fix: meta.filter in plugin doesn't work in response-rewrite plugin (apache#8162) feat: release 3.0 (apache#8179) docs: refactor admin api doc (apache#8145) docs: refactor health check doc (apache#8129) docs: protect-api.md typo, remove redundant braces. (apache#8139) feat: renew route lrucache when the routes change (apache#8157) ...
Description
Fixes #8114
the docs pr #8191
Checklist