fix: can not modify x-forwarded-host in proxy rewrite #8200
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
monkeyDluffy6017
changed the title
spacewander
reviewed
Oct 31, 2022
t/plugin/proxy-rewrite.t
Outdated
|
|
||
|
|
||
| === TEST 45: set route(rewrite host) | ||
| --- config |
There was a problem hiding this comment.
Let's add new test to https://github.com/apache/apisix/blob/master/t/plugin/proxy-rewrite3.t
t/plugin/proxy-rewrite.t
Outdated
|
|
||
|
|
||
|
|
||
| === TEST 45: set route(rewrite host) |
There was a problem hiding this comment.
The title is incorrect. We don't rewrite the host
tokers
reviewed
Nov 1, 2022
t/plugin/proxy-rewrite.t
Outdated
| @@ -34,7 +34,61 @@ run_tests; | |||
|
|
|||
| __DATA__ | |||
|
|
|||
| === TEST 1: sanity | |||
| === TEST 1: set route(rewrite host) | |||
There was a problem hiding this comment.
This case is samiliar to the one in proxy-rewrite-3.t?
spacewander
approved these changes
Nov 2, 2022
tzssangglass
approved these changes
Nov 2, 2022
Liu-Junlin
pushed a commit
to Liu-Junlin/apisix
that referenced
this pull request
Nov 4, 2022
hongbinhsu
added a commit
to fitphp/apix
that referenced
this pull request
Nov 7, 2022
* upstream/master: (94 commits) test: add test cases for ai module (apache#8222) fix(ai): typo key name (apache#8232) docs: update the docs of admin API (apache#8191) Update standalone docs for change in SSL parameter (apache#8242) fix: can not modify x-forwarded-host in proxy rewrite (apache#8200) chore: export the set cert/key process so we can hook it (apache#8228) test: add cases of ai module (apache#8214) feat: add dafault value roundrobin for upstream_schema (apache#8180) docs: update limit plugin docs (apache#8154) dix remote_addr (apache#8210) fix(zipkin): send trace IDs with a reject sampling decision (apache#8099) docs: update hmac-auth doc (apache#8192) docs: update limit count plugin doc (apache#8196) docs: fix building apisix misled (apache#8189) fix: meta.filter in plugin doesn't work in response-rewrite plugin (apache#8162) feat: release 3.0 (apache#8179) docs: refactor admin api doc (apache#8145) docs: refactor health check doc (apache#8129) docs: protect-api.md typo, remove redundant braces. (apache#8139) feat: renew route lrucache when the routes change (apache#8157) ...
spacewander
pushed a commit
to spacewander/incubator-apisix
that referenced
this pull request
Jan 28, 2023
Signed-off-by: spacewander <spacewanderlzx@gmail.com>
spacewander
pushed a commit
that referenced
this pull request
Jan 30, 2023
Signed-off-by: spacewander <spacewanderlzx@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
fix can not modify x-forwarded-host in proxy rewrite
Checklist