Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(csharp): Consider having ADO.NET wrapper return SqlDecimal for decimal128 #1230

Closed
CurtHagenlocher opened this issue Oct 26, 2023 · 0 comments
Closed

feat(csharp): Consider having ADO.NET wrapper return SqlDecimal for decimal128 #1230

CurtHagenlocher opened this issue Oct 26, 2023 · 0 comments
Milestone
ADBC Libraries 0.8.0

Comments

@CurtHagenlocher
Copy link
Contributor

Currently, the ADO.NET wrapper for ADBC converts decimal128 to System.Decimal with a fallback to string if the value is out-of-range. This doesn't seem great. It would be better to either return SqlDecimal for specific values of precision and scale or to have the fallback be to SqlDecimal instead of string.

Depends on apache/arrow#38351
@davidhcoe davidhcoe mentioned this issue Oct 31, 2023
Merged
CurtHagenlocher pushed a commit that referenced this issue Oct 31, 2023
@davidhcoe
feat(csharp): Add support for SqlDecimal (#1241)
2a74e8e 
This PR:

- Adds support for SqlDecimal for Decimal128 (follow up to
apache/arrow#38481)
- Treats Decimal256 values as string (follow up to
apache/arrow#38508)
- Adds a new DecimalBehavior to the Client to allow the caller to
determine how to treat decimal values
- Standardizes the test frameworks to Xunit

Addresses #1230

---------

Co-authored-by: David Coe <coedavid@umich.edu>
@lidavidm lidavidm added this to the ADBC Libraries 0.8.0 milestone Nov 1, 2023
vleslief-ms pushed a commit to vleslief-ms/arrow-adbc that referenced this issue Nov 9, 2023
@davidhcoe @vleslief-ms
feat(csharp): Add support for SqlDecimal (apache#1241)
58172ec 
This PR:

- Adds support for SqlDecimal for Decimal128 (follow up to
apache/arrow#38481)
- Treats Decimal256 values as string (follow up to
apache/arrow#38508)
- Adds a new DecimalBehavior to the Client to allow the caller to
determine how to treat decimal values
- Standardizes the test frameworks to Xunit

Addresses apache#1230

---------

Co-authored-by: David Coe <coedavid@umich.edu>
vleslief-ms pushed a commit to vleslief-ms/arrow-adbc that referenced this issue Nov 15, 2023
@davidhcoe @vleslief-ms
feat(csharp): Add support for SqlDecimal (apache#1241)
808c690 
This PR:

- Adds support for SqlDecimal for Decimal128 (follow up to
apache/arrow#38481)
- Treats Decimal256 values as string (follow up to
apache/arrow#38508)
- Adds a new DecimalBehavior to the Client to allow the caller to
determine how to treat decimal values
- Standardizes the test frameworks to Xunit

Addresses apache#1230

---------

Co-authored-by: David Coe <coedavid@umich.edu>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
ADBC Libraries 0.8.0
Development

No branches or pull requests
2 participants
@lidavidm @CurtHagenlocher