feat(csharp): Add support for SqlDecimal #1241
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…c into dev/sqldecimal
|
|
lidavidm
changed the title
CurtHagenlocher
requested changes
Oct 31, 2023
| @@ -331,155 +331,72 @@ public override unsafe UpdateResult ExecuteUpdate() | |||
|
|
|||
| public override object GetValue(IArrowArray arrowArray, Field field, int index) | |||
There was a problem hiding this comment.
Is there any real difference between this and the BigQueryStatement implementaton now? Could a base implementation be moved to AdbcStatement?
csharp/src/Client/AdbcDataReader.cs
Outdated
| if (value == null) | ||
| return null; | ||
|
|
||
| if(value.GetType() == typeof(SqlDecimal)) |
There was a problem hiding this comment.
if (value is SqlDecimal dvalue)
?
added 2 commits
October 31, 2023 12:06
CurtHagenlocher
approved these changes
Oct 31, 2023
vleslief-ms
pushed a commit
to vleslief-ms/arrow-adbc
that referenced
this pull request
Nov 9, 2023
This PR: - Adds support for SqlDecimal for Decimal128 (follow up to apache/arrow#38481) - Treats Decimal256 values as string (follow up to apache/arrow#38508) - Adds a new DecimalBehavior to the Client to allow the caller to determine how to treat decimal values - Standardizes the test frameworks to Xunit Addresses apache#1230 --------- Co-authored-by: David Coe <coedavid@umich.edu>
vleslief-ms
pushed a commit
to vleslief-ms/arrow-adbc
that referenced
this pull request
Nov 15, 2023
This PR: - Adds support for SqlDecimal for Decimal128 (follow up to apache/arrow#38481) - Treats Decimal256 values as string (follow up to apache/arrow#38508) - Adds a new DecimalBehavior to the Client to allow the caller to determine how to treat decimal values - Standardizes the test frameworks to Xunit Addresses apache#1230 --------- Co-authored-by: David Coe <coedavid@umich.edu>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR:
Addresses #1230