-
Notifications
You must be signed in to change notification settings - Fork 99
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(go): add basic driver logging #1048
Conversation
Bah, the experimental slog requires Go 1.20? |
@zeroshade how do you feel about bumping us to Go 1.20 or 1.21? I think the main problem will be Linux packaging jobs where we won't be able to use the system golang... |
Either that, or we can do build tag shenanigans to only enable this on Go 1.20? |
It looks like Arrow itself was bumped to Go 1.20: https://github.com/apache/arrow/blob/main/go/go.mod |
Arrow currently maintains compatibility with go1.17-go1.20. But as of apache/arrow#37637 we're dropping explicit compatibility with go1.17-go1.18. We're still keeping compatibility with go1.19 though, using build tags. What we could do here is put together a small interface and then use build tags to use https://pkg.go.dev/golang.org/x/exp/slog for go1.19 and |
It looks like slog works on 1.19 too so I'll see about bumping to 1.19 here |
Once I get this working I'll split out the version bump into a separate PR so that it's clear |
r/adbcflightsql/tools/download-go.R
Outdated
@@ -17,7 +17,7 @@ | |||
|
|||
tmp_dir <- "src/go/tmp" | |||
|
|||
go_version <- Sys.getenv("R_ADBC_GO_VERSION_DOWNLOAD", "1.18.10") | |||
go_version <- Sys.getenv("R_ADBC_GO_VERSION_DOWNLOAD", "1.19.13") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is there a canonical place in the repository where this value could be scraped? I am pretty sure I can make this automatic so that you don't have to do the version bump every time.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We could use the .env
but it's not in sync with everything else anyways (I guess it only affects docker-compose)
hmm, ubuntu-jammy fails because we install |
Windows verification is failing since libprotobuf now has a runtime dependency on gtest, and so when our verification script tries to remove it (since we want to use bundled gtest on windows) it also clobbers half our conda environment |
@kou do you know how to install I also tried installing both |
Hmm, let's see if alternative dependencies are the right thing to do... |
Alright, now the problem is that the |
@lidavidm you should be able to use this PPA to install golang-1.20
|
I don't think we want to ship binaries that depend on a PPA (and Go 1.20 is in the repos, just have to finagle the configuration) |
I didn't know there was an official package for go1.20 in the jammy repos |
OK, so long as the apt changes look OK, I'll split the Go version bump into a new PR, then come back here once that's merged |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1 for APT related changes.
Thanks Kou! Split into #1053 |
Fixes #492.