Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GH-37636: [Go] Bump minimum go versions #37637

Merged
merged 16 commits into from
Sep 13, 2023
Merged

GH-37636: [Go] Bump minimum go versions #37637

merged 16 commits into from
Sep 13, 2023

Conversation

zeroshade
Copy link
Member

@zeroshade zeroshade commented Sep 8, 2023 •
edited by github-actions bot
Loading

Updating the Github Actions workflows to only test Go 1.19 and Go 1.20 instead of Go1.17 and Go1.18. Also bumping the default Go version in the .env file to update the docker images.

@zeroshade zeroshade requested a review from lidavidm September 8, 2023 20:26
@github-actions
Copy link

github-actions bot commented Sep 8, 2023

⚠️ GitHub issue #37636 has been automatically assigned in GitHub to PR creator.

@github-actions github-actions bot added the awaiting committer review Awaiting committer review label Sep 8, 2023
@zeroshade
Copy link
Member Author

Hmm, gonna have to dig and see why those ASAN tests are failing for go1.19 😦

kou
kou reviewed Sep 8, 2023
View reviewed changes
.github/workflows/go.yml Outdated
runs-on: ubuntu-latest
staticcheck: v0.2.2
staticcheck: v0.4.5
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems that we always use staticcheck v0.4.5. Can we remove this parameter?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yea, we only needed it before because you couldn't use latest with go1.17, you had to use v0.2.2, and then we wanted to use the newer versions with go1.18. Now we can use the latest version with go1.19 and go1.20 but instead of using latest it's better to actually pin at v0.4.5. I've removed it from the parameters and just explicitly put it

.github/workflows/go.yml Outdated Show resolved Hide resolved
@github-actions github-actions bot added awaiting changes Awaiting changes and removed awaiting committer review Awaiting committer review labels Sep 8, 2023
assignUser
assignUser reviewed Sep 8, 2023
View reviewed changes
Copy link
Member

@assignUser assignUser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Always happy to see minimum versions being moved up 😀

.github/workflows/go.yml Outdated Show resolved Hide resolved
@github-actions github-actions bot added awaiting change review Awaiting change review and removed awaiting changes Awaiting changes labels Sep 11, 2023
@zeroshade zeroshade mentioned this pull request Sep 11, 2023
Merged
@github-actions github-actions bot added awaiting changes Awaiting changes and removed awaiting change review Awaiting change review labels Sep 11, 2023
@github-actions github-actions bot added awaiting change review Awaiting change review and removed awaiting changes Awaiting changes labels Sep 11, 2023
kou
kou reviewed Sep 12, 2023
View reviewed changes
.github/workflows/go.yml Outdated Show resolved Hide resolved
.github/workflows/go.yml Outdated Show resolved Hide resolved
.github/workflows/go.yml Outdated Show resolved Hide resolved
.github/workflows/go.yml Show resolved Hide resolved
.github/workflows/go.yml Show resolved Hide resolved
@github-actions github-actions bot added awaiting changes Awaiting changes and removed awaiting change review Awaiting change review labels Sep 12, 2023
zeroshade and others added 2 commits September 12, 2023 10:43
@zeroshade @kou
Update .github/workflows/go.yml
0b61c95 
Co-authored-by: Sutou Kouhei <kou@cozmixng.org>
@zeroshade @kou
Update .github/workflows/go.yml
37f8e4f 
Co-authored-by: Sutou Kouhei <kou@cozmixng.org>
@github-actions github-actions bot added awaiting change review Awaiting change review and removed awaiting changes Awaiting changes labels Sep 12, 2023
@zeroshade
Copy link
Member Author

@kou @assignUser this is ready for another review

kou
kou approved these changes Sep 13, 2023
View reviewed changes
Copy link
Member

@kou kou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

.github/workflows/go.yml Outdated Show resolved Hide resolved
.github/workflows/go.yml Outdated Show resolved Hide resolved
.github/workflows/go.yml Outdated Show resolved Hide resolved
.github/workflows/go.yml Outdated Show resolved Hide resolved
.github/workflows/go.yml Outdated Show resolved Hide resolved
.github/workflows/go.yml Outdated Show resolved Hide resolved
.github/workflows/go.yml Outdated Show resolved Hide resolved
.github/workflows/go.yml Outdated Show resolved Hide resolved
@github-actions github-actions bot added awaiting merge Awaiting merge awaiting review Awaiting review and removed awaiting change review Awaiting change review awaiting review Awaiting review awaiting merge Awaiting merge labels Sep 13, 2023
@assignUser assignUser merged commit 2a56d45 into apache:main Sep 13, 2023
@assignUser assignUser removed the awaiting review Awaiting review label Sep 13, 2023
@github-actions github-actions bot added the awaiting committer review Awaiting committer review label Sep 13, 2023
@zeroshade zeroshade deleted the bump-go-versions branch September 13, 2023 02:48
@conbench-apache-arrow
Copy link

After merging your PR, Conbench analyzed the 5 benchmarking runs that have been run so far on merge-commit 2a56d45.

There were no benchmark performance regressions. 🎉

The full Conbench report has more details. It also includes information about possible false positives for unstable benchmarks that are known to sometimes produce them.

loicalleyne pushed a commit to loicalleyne/arrow that referenced this pull request Nov 13, 2023
@zeroshade @kou @loicalleyne
apacheGH-37636: [Go] Bump minimum go versions (apache#37637)
b5724a3 
Updating the Github Actions workflows to only test Go 1.19 and Go 1.20 instead of Go1.17 and Go1.18. Also bumping the default Go version in the `.env` file to update the docker images.
* Closes: apache#37636

Lead-authored-by: Matt Topol <zotthewizard@gmail.com>
Co-authored-by: Sutou Kouhei <kou@cozmixng.org>
Signed-off-by: Jacob Wujciak-Jens <jacob@wujciak.de>
dgreiss pushed a commit to dgreiss/arrow that referenced this pull request Feb 19, 2024
@zeroshade @kou @dgreiss
apacheGH-37636: [Go] Bump minimum go versions (apache#37637)
cfcb374 
Updating the Github Actions workflows to only test Go 1.19 and Go 1.20 instead of Go1.17 and Go1.18. Also bumping the default Go version in the `.env` file to update the docker images.
* Closes: apache#37636

Lead-authored-by: Matt Topol <zotthewizard@gmail.com>
Co-authored-by: Sutou Kouhei <kou@cozmixng.org>
Signed-off-by: Jacob Wujciak-Jens <jacob@wujciak.de>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@assignUser assignUser assignUser approved these changes

@kou kou kou approved these changes

@lidavidm lidavidm Awaiting requested review from lidavidm

@raulcd raulcd Awaiting requested review from raulcd raulcd is a code owner

Assignees
No one assigned
Labels
awaiting committer review Awaiting committer review Component: Go
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Go] Bump minimum Go version
3 participants
@zeroshade @kou @assignUser