Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

enable ipc compression feature for integration test #2462

Merged
merged 1 commit into from
Aug 16, 2022
Merged

enable ipc compression feature for integration test #2462

merged 1 commit into from
Aug 16, 2022

Conversation

liukun4515
Copy link
Contributor

Which issue does this PR close?

Closes #1907

Rationale for this change

What changes are included in this PR?

Are there any user-facing changes?

@liukun4515 liukun4515 mentioned this pull request Aug 16, 2022
Merged
liukun4515
liukun4515 commented Aug 16, 2022
View reviewed changes
integration-testing/Cargo.toml
@@ -31,7 +31,7 @@ rust-version = "1.62"
logging = ["tracing-subscriber"]

[dependencies]
arrow = { path = "../arrow", default-features = false, features = [ "test_utils" ] }
arrow = { path = "../arrow", default-features = false, features = [ "test_utils", "ipc_compression" ] }
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

enable feature for the default build

@liukun4515
Copy link
Contributor Author

PTAL @alamb

@tustvold tustvold merged commit 7a74465 into apache:master Aug 16, 2022
@ursabot
Copy link

ursabot commented Aug 16, 2022

Benchmark runs are scheduled for baseline = 3b59adc and contender = 7a74465. 7a74465 is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Skipped ⚠️ Benchmarking of arrow-rs-commits is not supported on ec2-t3-xlarge-us-east-2] ec2-t3-xlarge-us-east-2
[Skipped ⚠️ Benchmarking of arrow-rs-commits is not supported on test-mac-arm] test-mac-arm
[Skipped ⚠️ Benchmarking of arrow-rs-commits is not supported on ursa-i9-9960x] ursa-i9-9960x
[Skipped ⚠️ Benchmarking of arrow-rs-commits is not supported on ursa-thinkcentre-m75q] ursa-thinkcentre-m75q
Buildkite builds:
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python, R. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java

@alamb
Copy link
Contributor

alamb commented Aug 16, 2022 •
edited
Loading

nice -- thanks @liukun4515

@alamb alamb changed the title enable compression for IT enable ipc compression feature for integration test Aug 16, 2022
@tustvold tustvold added the development-process Related to development process of arrow-rs label Sep 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tustvold tustvold tustvold approved these changes

Assignees
No one assigned
Labels
development-process Related to development process of arrow-rs
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

enable the IT test for 2.0.0-compression
4 participants
@liukun4515 @ursabot @alamb @tustvold