Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ARROW-16861: [Rust][Integration] Enable IP compression for Rust #13893

Merged
merged 1 commit into from
Aug 17, 2022

Conversation

liukun4515
Copy link
Contributor

@liukun4515 liukun4515 commented Aug 16, 2022

@liukun4515
Copy link
Contributor Author

@alamb PTAL

@alamb alamb changed the title enable compression IT for rust [ARROW-16861] enable compression IT for rust Aug 16, 2022
@alamb alamb changed the title [ARROW-16861] enable compression IT for rust ARROW-16861: [Rust][Integration] Enable IP compression for Rust Aug 16, 2022
@github-actions
Copy link

@github-actions
Copy link

⚠️ Ticket has not been started in JIRA, please click 'Start Progress'.

@alamb
Copy link
Contributor

alamb commented Aug 16, 2022

https://github.com/apache/arrow/runs/7854025490?check_suite_focus=true seems to have failed.

I was thinking it may be related to running before apache/arrow-rs#2462 was merged. To confirm/deny this hypothesis I have retriggered the run

@liukun4515 liukun4515 force-pushed the enable_coompression_it branch from 5339a31 to 53aa31a Compare August 17, 2022 01:42
@liukun4515
Copy link
Contributor Author

Maybe it can be merged. @alamb

@alamb
Copy link
Contributor

alamb commented Aug 17, 2022

Indeed the tests are passing. I will merge this (via the merge.py script)

@alamb
Copy link
Contributor

alamb commented Aug 17, 2022

🤔 I am having trouble merging in

(arrow_dev) alamb@MacBook-Pro-8:~/Software/arrow$ ./dev/merge_arrow_pr.py 13893
ARROW_HOME = /Users/alamb/Software/arrow/dev
PROJECT_NAME = arrow

=== Pull Request #13893 ===
title	ARROW-16861: [Rust][Integration] Enable IP compression for Rust
source	liukun4515/enable_coompression_it
target	master
url	https://api.github.com/repos/apache/arrow/pulls/13893
=== JIRA ARROW-16861 ===
Summary		[Rust] enable integration test for 2.0.0 compression for rust version
Assignee	Andrew Lamb
Components	Rust
Status		In Progress
URL		https://issues.apache.org/jira/browse/ARROW-16861

Proceed with merging pull request #13893? (y/n): y
Author 1: liukun4515 <liukun@apache.org>
Traceback (most recent call last):
  File "/Users/alamb/Software/arrow/./dev/merge_arrow_pr.py", line 600, in <module>
    cli()
  File "/Users/alamb/Software/arrow/./dev/merge_arrow_pr.py", line 580, in cli
    pr.merge()
  File "/Users/alamb/Software/arrow/./dev/merge_arrow_pr.py", line 459, in merge
    self.cmd.fail(f'Failed to merge pull request: {message}')
  File "/Users/alamb/Software/arrow/./dev/merge_arrow_pr.py", line 306, in fail
    raise Exception(msg)
Exception: Failed to merge pull request: Not Found: https://api.github.com/repos/apache/arrow/pulls/13893/merge

I will try again later today to see if it is some sort of transient error

@alamb
Copy link
Contributor

alamb commented Aug 17, 2022

Well, the merge script is still not working, so I will merge this PR in manually and close the JIRA

@alamb alamb merged commit cef6894 into apache:master Aug 17, 2022
@ursabot
Copy link

ursabot commented Aug 17, 2022

Benchmark runs are scheduled for baseline = 951663a and contender = cef6894. cef6894 is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Finished ⬇️0.0% ⬆️0.0%] ec2-t3-xlarge-us-east-2
[Finished ⬇️1.94% ⬆️1.26%] test-mac-arm
[Failed] ursa-i9-9960x
[Failed] ursa-thinkcentre-m75q
Buildkite builds:
[Finished] cef68940 ec2-t3-xlarge-us-east-2
[Finished] cef68940 test-mac-arm
[Failed] cef68940 ursa-i9-9960x
[Failed] cef68940 ursa-thinkcentre-m75q
[Finished] 951663a4 ec2-t3-xlarge-us-east-2
[Finished] 951663a4 test-mac-arm
[Failed] 951663a4 ursa-i9-9960x
[Finished] 951663a4 ursa-thinkcentre-m75q
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python, R. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java

@ursabot
Copy link

ursabot commented Aug 17, 2022

['Python', 'R'] benchmarks have high level of regressions.
test-mac-arm

zagto pushed a commit to zagto/arrow that referenced this pull request Oct 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants