-
Notifications
You must be signed in to change notification settings - Fork 109
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Dev] Update the merge_pr script to work with GitHub issues #285
Comments
🤔 I have just been using the merge button recently. I am sorry if that caused problems 🤔 |
I don't think that causes any problems ;) I also often have used the merge button here on the arrow-site repo (not all PRs here were always linked to a JIRA issue, so then there is not that much need to use the merge script) IMO it would be fine to just start using the merge button for all PRs here. |
Can we change the default commit message to "Default to pull request title and description" if we always use the merge button? |
I can't find anything on the configuration for the I would propose at this point to remove both the title PR checkers on this repo and the merge script. I am happy to implement a different title checker but if we take a look at the closed PRs we are defacto ignoring the merge script and using the merge button and ignoring the title PR check for this repo. |
Also in the exceptional case of an issue being opened on the main Arrow repo that relates to the |
Could you open an INFRA Jira issue? |
We can indeed "transfer" issues between repos (for people with commit rights, the button for this is at the bottom of the right sidebar) |
I have created the following INFRA Jira issue to track this request: https://issues.apache.org/jira/browse/INFRA-24122 |
…ite (#303) As discussed on #285 currently we don't check the PR titles nor use the merge script. We could implement some PR checker but if we take a look on the Closed PRs almost none of them are following the structure and we don't seem to use the merge script at all and always use the merge button. At this point I would propose to just remove this files. Closes #285
The merge_pr script on the arrow-site repo is quite outdated. It still uses JIRA user and password instead of token (https://github.com/apache/arrow-site/blob/master/scripts/merge_pr.py#L31-L32) and it does not work with GitHub issues. We should update it. Probably copying the one from the Arrow repo (https://github.com/apache/arrow/blob/master/dev/merge_arrow_pr.py) and updating some defaults for repo-name, etcetera should be enough.
The text was updated successfully, but these errors were encountered: